96 Commits

Author SHA1 Message Date
77b9aac6c2 Add rule for typechecking maintainers (#161307)
Allow the following people merge rights on type checking configs:
  - @lolpack
  - @maggiemoss
  - @ndmitchell
  - @kinto0

Pull Request resolved: https://github.com/pytorch/pytorch/pull/161307
Approved by: https://github.com/albanD, https://github.com/ezyang
2025-09-25 00:14:31 +00:00
690fc9cf88 [merge_rules] add some expected failure and skips (#159581)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/159581
Approved by: https://github.com/anijain2305
2025-08-01 01:18:40 +00:00
d61153a300 Delete mobile merge rule (#158963)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158963
Approved by: https://github.com/atalman
ghstack dependencies: #158961, #158962
2025-07-24 02:34:27 +00:00
56d07d0bde Add merge_rules category for Dynamo; add guilhermeleobas (#158620)
Adds guilhermeleobas to merge_rules for Dynamo and functorch.
Guilherme has done good work on both of these subsystems and I am tired
of him approving my PRs and me not being able to merge them.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158620
Approved by: https://github.com/anijain2305
2025-07-23 00:44:27 +00:00
b3c868d603 [vllm]Add vllm.txt for pinned commit (#158754)
It seems the nightly.yml won't auto-generate txt file when it does not existed, so added the file with latest merged commit from vllm:

[vllm commit](https://github.com/vllm-project/vllm/commits/main)

Error:
https://github.com/pytorch/pytorch/actions/runs/16405915719/job/46351847504
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158754
Approved by: https://github.com/huydhn
2025-07-21 22:41:07 +00:00
be483a5481 setup pinned commit for vllm in pytorch ci (#158591)
Set up pinned commit for vllm in nightly
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158591
Approved by: https://github.com/seemethere, https://github.com/huydhn
2025-07-18 22:30:20 +00:00
795a6a0aff Update github first merge rule (#156583)
**Summary**
Update the merge rules for `CPU Frontend` and `Autocast`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/156583
Approved by: https://github.com/atalman
2025-06-24 14:04:22 +00:00
462579af11 Update merge_rules.yaml (#155008)
- add new docs reviewers

Pull Request resolved: https://github.com/pytorch/pytorch/pull/155008
Approved by: https://github.com/malfet
2025-06-03 18:09:23 +00:00
40e6ca24ef Update CPU Inductor merge rules by adding more CPP Template (#152086)
**Summary**
Add more CPP Template into the CPU Inductor merge rules.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/152086
Approved by: https://github.com/atalman
2025-05-22 09:46:26 +00:00
cda572b053 codecache: Remove cpp_prefix.h duplication per build, then precompile it (#144293)
Prior to this PR, `_inductor/codegen/cpp_prefix.h` was copied into a new temporary directory on every inductor run utilizing the CPP backend (i.e. CPU-only), then included in the output source code. Instead, this PR puts it in an appropriate place in the torch includes, and includes it from there. This allows us to precompile it in cpp_wrapper and AOT inductor mode, saving significant compilation time.

Due to difficulties getting this to work in FBCode, the precompilation itself is only enabled in OSS PyTorch.

Differential Revision: [D69420620](https://our.internmc.facebook.com/intern/diff/D69420620)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144293
Approved by: https://github.com/desertfire
2025-05-16 17:41:36 +00:00
13f48197d2 Add Chillee as core reviewer (#150579)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/150579
Approved by: https://github.com/albanD, https://github.com/drisspg, https://github.com/malfet
2025-04-03 00:40:06 +00:00
2cc3f5030a Add XPU and SYCL Merge Patterns (#149933)
As the title

Pull Request resolved: https://github.com/pytorch/pytorch/pull/149933
Approved by: https://github.com/atalman
2025-03-25 16:03:29 +00:00
b63c601614 Update merge rules for oneDNN part (#147615)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/147615
Approved by: https://github.com/atalman
2025-02-25 11:26:59 +00:00
3008368b12 Honor Dr.CI classification results on auto commit hash update (#146337)
Disable `ignore_flaky_failures` was a safer choice, but it seems that this option doesn't work with the current state of the CI.  For example, https://github.com/pytorch/pytorch/pull/125806 hasn't been merged since May because there would always be a failure in one type or another.  This effectively disables the automate mechanism.

My proposal here is to relax this rule and allows the bot to merge auto commit has update with `@pytorchbot merge` like a regular PR.  Then we will at least have something working.  If this causes issue, we can revert it back and try to longer route of improving CI reliability.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/146337
Approved by: https://github.com/clee2000
2025-02-06 20:33:38 +00:00
266fd35c58 Fix ExecuTorch, XLA, Triton hash updates (#145314)
Fix some stale hash updates https://github.com/pytorch/pytorch/pulls/pytorchupdatebot reported by @izaitsevfb

* XLA and ExecuTorch now wait for all jobs in pull instead of hardcoding the job names which are not correct anymore and the bot waits forever there
* Trion commit hash hasn't been updated automatically since 2023 and people have been updating the pin manually with their testings from time to time, so I doubt that it would be an useful thing to keep.

The vision update failures looks more complex though and I would need to take a closer look.  So, I will keep it in another PR
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145314
Approved by: https://github.com/izaitsevfb
2025-01-21 23:24:21 +00:00
dbed747aae Add Intel GPU specific CMake files to merge rules (#135110)
As the title.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/135110
Approved by: https://github.com/atalman
2025-01-17 09:44:13 +00:00
b51b7e28ee Add DCP doc to DCP merge-rules (#139938)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/139938
Approved by: https://github.com/LucasLLC, https://github.com/c-p-i-o, https://github.com/fduwjj
2024-11-07 02:19:49 +00:00
b57d67e263 Add isuruf to core reviewers (#136554)
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136554
Approved by: https://github.com/Skylion007, https://github.com/malfet
2024-09-24 23:06:46 +00:00
18a9030952 [CI] Fix update slow tests (#135390)
* Add pytorchbot to list of approvers for file
* Add labels to the auto created PR

The auto generated PR is currently not merging due to some failing tests on slow workflow that were supposed to be moved back to normal

idk if this has much value, clearly we've been managing without the update
Pull Request resolved: https://github.com/pytorch/pytorch/pull/135390
Approved by: https://github.com/ZainRizvi
2024-09-11 17:02:17 +00:00
6180574771 Move py 3.8->3.9 pull, trunk, inductor, prerioric CI tests (#133624)
Part of Deprecation of python 3.8 and moving to 3.9. Related to: https://github.com/pytorch/pytorch/issues/120718
Except XPU and ROCM jobs

Pull Request resolved: https://github.com/pytorch/pytorch/pull/133624
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/ZainRizvi
2024-08-29 19:15:59 +00:00
2553278bae .github/merge_rules.yaml: added multiprocessing to Distributed (#134262)
This allows the Distributed team to approve changes to torch.multiprocessing which is used by torchelastic/run.

Example PR: https://github.com/pytorch/pytorch/pull/133707

Pull Request resolved: https://github.com/pytorch/pytorch/pull/134262
Approved by: https://github.com/wconstab, https://github.com/PaliC
2024-08-23 17:07:20 +00:00
6955bc170d Some updates to merge rules (#132296)
The added people from metamates don't actually make a material
difference right now but I added some for fun.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132296
Approved by: https://github.com/albanD, https://github.com/malfet
2024-07-31 19:49:08 +00:00
e29657efb6 [Inductor][CPP] Fix typo in merge rules (#130405)
**Summary**
There is a typo of the `CPU Inductor` group in `merge_rules.yaml` which should be `test/inductor/test_cpu_repro.py` instead of `test/inductor/test_cpu_repo.py`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/130405
Approved by: https://github.com/jgong5, https://github.com/lezcano
2024-07-10 07:13:03 +00:00
18e75c098b [DCP] Adds Checkpointing Team (dcp) to merge rules (#129582)
[DCP] Adds Checkpointing Team (dcp) to merge rules. Please comment to this PR if you think you should be added as well!
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129582
Approved by: https://github.com/fegin
2024-07-05 20:09:31 +00:00
cb126711cd [merge_rule] add more cpp inductor files (#129192)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/129192
Approved by: https://github.com/leslie-fang-intel, https://github.com/atalman
2024-06-22 09:04:14 +00:00
ab13980424 [ONNX] Update 'person_of_interest.rst', 'CODEOWNERS' and 'merge_rules.yaml' (#126364)
The following are all constrained under the ONNX exporter project scope.

- `personal_of_interest.rst`
  - Moving folks no longer working on the project to emeritus.
  - Adding @justinchuby, @titaiwangms, @shubhambhokare1 and @xadupre,
    who have all made countless contributions to this project.
- `CODEOWNERS`
  - Removing folks no longer working on the project.
  - Updating new owners who will now be notified with PRs related to
    the specific file paths.
- `merge_rules.yaml`
  - Removing folks no longer working on the project.

🫡

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/126364
Approved by: https://github.com/titaiwangms, https://github.com/justinchuby, https://github.com/albanD
2024-06-16 04:52:16 +00:00
14c9eb5ed2 Add XPU code owners (#128486)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128486
Approved by: https://github.com/atalman, https://github.com/malfet
2024-06-13 06:33:45 +00:00
8d7393cb5e Update triton-xpu commit pin merge rules for XPU (#127203)
Add the ".ci/docker/ci_commit_pins/triton-xpu.txt" to the XPU merge rules.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/127203
Approved by: https://github.com/atalman
2024-05-31 17:19:19 +00:00
9f1d3eebf5 Update PyTorch ONNX Exporter maintainers (#125630)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/125630
Approved by: https://github.com/BowenBao, https://github.com/kit1980
2024-05-07 17:29:05 +00:00
7706cd7d12 Extend CPU inductor merge rule (#124671)
To help unblock: https://github.com/pytorch/pytorch/pull/123710
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124671
Approved by: https://github.com/leslie-fang-intel, https://github.com/huydhn
2024-04-23 02:18:00 +00:00
5a735ece6b Remove @abock from ONNX approvers/codeowners (#124259)
As he is no longer interested in the project
Pull Request resolved: https://github.com/pytorch/pytorch/pull/124259
Approved by: https://github.com/kit1980, https://github.com/BowenBao
2024-04-17 14:13:53 +00:00
98cf183629 [merge rules] add mkldnn_lowerings.py to CPU inductor rule (#123627)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/123627
Approved by: https://github.com/kit1980
2024-04-09 04:07:20 +00:00
2964b1ef21 Extend XPU merge rules: Add torch/csrc/xpu/, torch/xpu/ and test/xpu (#122856)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/122856
Approved by: https://github.com/atalman, https://github.com/malfet
2024-04-03 00:52:08 +00:00
30a579dba3 Add XPU ATen merge rule (#122484)
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/122484
Approved by: https://github.com/huydhn, https://github.com/malfet
2024-03-26 16:20:48 +00:00
3e8c8ce37b Update Reviewers for PT-D team (#117409)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/117409
Approved by: https://github.com/fegin, https://github.com/awgu, https://github.com/fduwjj
2024-01-16 19:40:41 +00:00
302f931c25 Update Reviewers for PyTorch Distributed team (#116231)
Update merge rule approver list under 'Distributed' section based on current PyTorch distributed team composition.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/116231
Approved by: https://github.com/fduwjj, https://github.com/XilunWu
2024-01-13 05:07:13 +00:00
7073dc604e Merge merging rules of CPU inductor and x86 CPU quantization (#116937)
**Summary**
Following the discussion at https://github.com/pytorch/pytorch/pull/116599#issuecomment-1878757581, due to the limitation of the current merging rules that prevent cross-checking all files among different merge groups, it is proposed to merge the groups `x86 CPU quantization` and `CPU inductor` since they are closely related.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/116937
Approved by: https://github.com/jgong5, https://github.com/atalman
2024-01-08 15:32:03 +00:00
3407541b0c add cpu inductor merge rule (#116679)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/116679
Approved by: https://github.com/huydhn
2024-01-03 15:09:36 +00:00
fdf8718225 Update reviewes for PyTorch Distributed (#116296)
Summary:
Add shuqiangzhang as a reviewer
Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Pull Request resolved: https://github.com/pytorch/pytorch/pull/116296
Approved by: https://github.com/fduwjj
2023-12-22 02:49:51 +00:00
cfbf647adb Add aten/src/ATen/native/quantized/cpu/ path to CPU quantization merge rule (#116145)
Observing following PR: https://github.com/pytorch/pytorch/pull/115329
Comment from author: https://github.com/pytorch/pytorch/pull/115329#issuecomment-1851339555

pytorchbot merge failed.
Reason is this logic, we expect all files in PR to match one merge rule:
110339a310/.github/scripts/trymerge.py (L1310-L1324)

This should mitigate the issue, followup will post a PR to refactor this code to allow cross rule matching of approvers
Pull Request resolved: https://github.com/pytorch/pytorch/pull/116145
Approved by: https://github.com/huydhn, https://github.com/kit1980, https://github.com/malfet
2023-12-20 14:43:15 +00:00
af5a3bda45 [merge rule] add CPU quantization (#114994)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114994
Approved by: https://github.com/jerryzh168, https://github.com/malfet
2023-12-02 08:34:55 +00:00
7daeb6509f Update audio pinned commit nightly (#114426)
I think we could have this pinned commit being update nightly like what we have with vision.  This will avoid having an outdated audio pinned commit that needs to be updated manually, i.e. https://github.com/pytorch/pytorch/pull/114393
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114426
Approved by: https://github.com/atalman, https://github.com/seemethere, https://github.com/malfet
2023-11-23 07:36:55 +00:00
81f93991d3 Update merge rule to allow pytorchbot to land ExecuTorch hash update (#114180)
The bot cannot merge the hash update PR otherwise, for example https://github.com/pytorch/pytorch/pull/114008#issuecomment-1818032181.  I also need to move ExecuTorch jobs in trunk to pull to match the rule without the need to add `ciflow/trunk` label.  The test job takes less than 20 minutes to finish atm on `2xlarge`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/114180
Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/malfet
2023-11-21 01:36:52 +00:00
625a3b1a42 Remove some patterns from PrimTorch merge rules (#111230)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/111230
Approved by: https://github.com/ezyang
2023-10-13 20:37:15 +00:00
85e408217a [ONNX] Move out onnx bench bash scripts (#103983)
Summary:
- Remove onnx bench related scripts and `_onnx` folder.
- Update `common.py` to include onnx related patches previously under `_onnx` folder.
- Update `merge_rules.json` to include bench files.
- Added quick sanity onnx bench test to onnx CI.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/103983
Approved by: https://github.com/kit1980
2023-09-27 23:54:26 +00:00
ae064ad4c6 Fix XLA update rules (#110177)
Regression introduced during migration of `bionic` to `focal` by https://github.com/pytorch/pytorch/pull/105260

Pull Request resolved: https://github.com/pytorch/pytorch/pull/110177
Approved by: https://github.com/clee2000
2023-09-27 19:25:31 +00:00
0edb616793 Add test/onnx_caffe2 to ONNX Exporter merge rule (#109295)
As we deprecate the TorchScript ONNX exporter we need to refactor the onnx caffe2 tests to start using private functions instead of public ones

That requires changes to the merge rules to allow ONNX exporter to drive deprecation
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109295
Approved by: https://github.com/malfet
2023-09-14 19:06:12 +00:00
aa3355da8a Refactor torch.onnx documentation (#108379)
* Distinguish both TorchScript-based exporter (`torch.onnx.export`) and the TorchDynamo-based exporter (`torch.onnx.dynamo_export`) exporters
* Merge ONNX diagnostics page with the exporter page
* Add initial version of a quick overview on the new exporter
* Updates `torch.compiler.html` with the right page for the ONNX Runtime backend for `torch.compile`
* Renamed doc files to clearly identify files belonging to the legacy and newer onnx exporters

Fixes #108274

https://docs-preview.pytorch.org/pytorch/pytorch/108379/index.html
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108379
Approved by: https://github.com/justinchuby, https://github.com/wschin, https://github.com/malfet
2023-09-08 18:23:48 +00:00
cyy
c24d0d3163 clang8=>clang9 in jobs (#107144)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107144
Approved by: https://github.com/malfet
2023-08-31 06:51:58 +00:00
22f5889753 [Dynamo, ONNX] Replace onnxrt backend with new backend from ONNXRuntime team (#106929)
In https://github.com/pytorch/pytorch/pull/106589, a new ONNXRuntime-based Dynamo backend is introduced. As mentioned in that PR, we hope to replace legacy `onnxrt` with that new backend. This PR remove legacy `onnxrt` and register the new backend under the same name.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/106929
Approved by: https://github.com/thiagocrepaldi, https://github.com/BowenBao, https://github.com/abock, https://github.com/msaroufim, https://github.com/jansel
2023-08-15 22:50:46 +00:00