8 Commits

Author SHA1 Message Date
3924aa75b1 [BE] Extend linter to detect DOS newlines (#86973)
Fix DOS newlines in `onednn/decompose_silu.[cpp|h]` introduced by https://github.com/pytorch/pytorch/pull/85591 as well as one in `.github/PULL_REQUEST_TEMPLATE.md`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/86973
Approved by: https://github.com/huydhn, https://github.com/izaitsevfb
2022-10-15 00:20:42 +00:00
dc51fc71fc Revert "Update the pull request template (#81991)" (#83025)
This reverts commit 89a6680036ee4371caad48e753d3d5e2ec4604ea as it seems
to be filled in very sporadically

See discussion in https://github.com/pytorch/pytorch/issues/83024
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83025
Approved by: https://github.com/seemethere, https://github.com/janeyx99
2022-08-08 21:54:37 +00:00
89a6680036 Update the pull request template (#81991)
### Description
Makes the pull request template more useful by adding a couple concrete sections which should usually be filled out

Pull Request resolved: https://github.com/pytorch/pytorch/pull/81991
Approved by: https://github.com/huydhn
2022-07-22 19:29:21 +00:00
54406314cc Update PULL_REQUEST_TEMPLATE.md (#70105)
Summary:
Many users actually send things like `Fixes #{69696}` which then fails to properly close the corresponding issue.

Fixes #{issue number}

Pull Request resolved: https://github.com/pytorch/pytorch/pull/70105

Reviewed By: ejguan

Differential Revision: D33187501

Pulled By: albanD

fbshipit-source-id: 2080ee42c30b9db45177f049627118a6c3b544b7
2021-12-17 07:53:36 -08:00
e42eab4b1c Update PULL_REQUEST_TEMPLATE.md (#41812)
Summary:
**Summary**
This commit updates the repository's pull request template to remind contributors to tag the issue that their pull request addresses.

**Fixes**
This commit fixes https://github.com/pytorch/pytorch/issues/35319.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/41812

Reviewed By: gmagogsfm

Differential Revision: D22667902

Pulled By: SplitInfinity

fbshipit-source-id: cda5ff7cbbbfeb89c589fd0dfd378bf73a59d77b
2020-07-23 21:30:43 -07:00
b774ce54f8 remediation of S205607
fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3
2020-07-17 17:19:47 -07:00
8fdea489af remediation of S205607
fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac
2020-07-17 17:17:03 -07:00
d84033dc6b Add placeholders for issues/pull requests
Summary: Closes https://github.com/caffe2/caffe2/pull/1604

Differential Revision: D6537325

Pulled By: pietern

fbshipit-source-id: 90dae8389e318ff36c8455a0e002c8e42167aa9a
2017-12-11 14:35:25 -08:00