frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename c10::detail to c10::impl (#13838)

Browse Source 
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/13838

According to Sebastian, the detail convention is specifically for header-private
functionality.  That's not what c10/detail is; it's general, library private headers
which may be used in multiple places within PyTorch.  Rename it to impl to avoid
the confusion in nomenclature.

Reviewed By: smessmer

Differential Revision: D13024368

fbshipit-source-id: 050f2632d83a69e3ae53ded88e8f938c5d61f0ef
This commit is contained in:
Edward Yang
2018-11-14 07:25:52 -08:00
committed by Facebook Github Bot
parent db5aeafa60
commit fbabe5bf62
18 changed files with 59 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
setup.py
View File

@ -1214,7 +1214,7 @@ if __name__ == '__main__':
'lib/include/c10/*.h',
'lib/include/c10/macros/*.h',
'lib/include/c10/util/*.h',
'lib/include/c10/detail/*.h',
'lib/include/c10/impl/*.h',
'lib/include/caffe2/core/*.h',
'lib/include/caffe2/proto/*.h',
'lib/include/torch/*.h',