mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-21 13:44:15 +08:00
add hud link to merge failure message (#83946)
as in title, related to https://github.com/pytorch/test-infra/issues/568 Pull Request resolved: https://github.com/pytorch/pytorch/pull/83946 Approved by: https://github.com/huydhn
This commit is contained in:
committed by
PyTorch MergeBot
parent
3a9ae518f2
commit
f7e668b7b5
16
.github/scripts/trymerge.py
vendored
16
.github/scripts/trymerge.py
vendored
@ -1043,14 +1043,20 @@ def find_matching_merge_rule(pr: GitHubPR,
|
||||
if len(failed_checks) > 0:
|
||||
if reject_reason_score < 30000:
|
||||
reject_reason_score = 30000
|
||||
reject_reason = ("Refusing to merge as mandatory check(s) " +
|
||||
checks_to_str(failed_checks) + f" failed for rule {rule_name}")
|
||||
reject_reason = (
|
||||
f"[View failures on hud](https://hud.pytorch.org/{pr.org}/{pr.project}/commit/{pr.last_commit()['oid']}). "
|
||||
+ f"Refusing to merge as mandatory check(s) {checks_to_str(failed_checks)} failed for "
|
||||
+ f"rule {rule_name}."
|
||||
)
|
||||
continue
|
||||
elif len(pending_checks) > 0:
|
||||
if reject_reason_score < 20000:
|
||||
reject_reason_score = 20000
|
||||
reject_reason = f"Refusing to merge as mandatory check(s) {checks_to_str(pending_checks)}"
|
||||
reject_reason += f" are pending/not yet run for rule {rule_name}"
|
||||
reject_reason = (
|
||||
f"[View pending jobs on hud](https://hud.pytorch.org/{pr.org}/{pr.project}/commit/{pr.last_commit()['oid']}). "
|
||||
+ f"Refusing to merge as mandatory check(s) {checks_to_str(pending_checks)} are pending/not yet run for "
|
||||
+ f"rule {rule_name}."
|
||||
)
|
||||
continue
|
||||
if not skip_internal_checks and pr.has_internal_changes():
|
||||
raise RuntimeError("This PR has internal changes and must be landed via Phabricator")
|
||||
@ -1323,7 +1329,7 @@ def main() -> None:
|
||||
msg += f"\nReason: {e}"
|
||||
run_url = os.getenv("GH_RUN_URL")
|
||||
if run_url is not None:
|
||||
msg += f"\nRaised by {run_url}"
|
||||
msg += f"\nRaised by [workflow job]({run_url})"
|
||||
if args.land_checks:
|
||||
msg += get_land_check_troubleshooting_message()
|
||||
gh_post_pr_comment(org, project, args.pr_num, msg, dry_run=args.dry_run)
|
||||
|
Reference in New Issue
Block a user