frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Checks kv pair indexing in OrderedPreservingDictTest.test_range_insert (#148136)

Browse Source 
`OrderedPreservingDictTest.test_range_insert` has an [unused loop variable `j`](https://github.com/pytorch/pytorch/blob/main/c10/test/util/ordered_preserving_dict_test.cpp#L186), I think taken from the [inspired project](https://github.com/pytorch/pytorch/blob/main/c10/test/util/ordered_preserving_dict_test.cpp#L165) testcase for range inserts, where it [checks kv pair indexing/order](https://github.com/Tessil/ordered-map/blob/master/tests/ordered_map_tests.cpp#L136) for the ordered dict.

This just adds in that functionality to the test case.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/148136
Approved by: https://github.com/eellison
This commit is contained in:
redwrasse
2025-05-14 06:05:23 +00:00
committed by PyTorch MergeBot
parent 11c64b7cf8
commit f7798d8645
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
c10/test/util/ordered_preserving_dict_test.cpp
View File

@ -183,8 +183,15 @@ TEST(OrderedPreservingDictTest, test_range_insert) {
ASSERT_EQUAL_PRIM(map.at(-2), 0);
for (int i = 10, j = 2; i < nb_values - 5; i++, j++) {
auto begin = map.begin();
begin++;
begin++;
for (int i = 10; i < nb_values - 5; i++, begin++) {
// Check range inserted kv pairs: map(i) = i + 1 for i = 10,....995
ASSERT_EQUAL_PRIM(map.at(i), i + 1);
// Check range inserted kv pairs are correctly indexed/ordered
TORCH_INTERNAL_ASSERT(begin->first == i);
TORCH_INTERNAL_ASSERT(begin->second == i + 1);
}
}