From e2b7f0bfd2b4fa0bb9e10002ef105efeefccae81 Mon Sep 17 00:00:00 2001 From: Fabian Marin Date: Thu, 14 Nov 2024 00:35:55 +0000 Subject: [PATCH] =?UTF-8?q?clarifies=20the=20wording=20in=20the=20main=20R?= =?UTF-8?q?EADME=20to=20make=20it=20clearer=20that=20visu=E2=80=A6=20(#140?= =?UTF-8?q?442)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …al studio build tool is only needed for Windows I created no issue since the suggested change is actually very small. This is my very first PR so partly I am creating it just to dip my toes in the water. In fact I would understand if the change does not get accepted since it's a simple modification to part of the wording in the README. The wording as it currently stands is probably clear enough for most people, but I still missed the fact that visual studio build tool must only be installed for Windows (even though that is stated there), and I thought by adding some parentheses this might become even more clear, specially since elsewhere in the README the formatting makes it more explicit that some steps must only be run for Windows/Linux/MacOS As I said, it's a trivial change so I'd understand if it's not accepted, and I am looking forward to making more meaningful contributions as time goes on. Fixes #ISSUE_NUMBER Pull Request resolved: https://github.com/pytorch/pytorch/pull/140442 Approved by: https://github.com/soulitzer --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e32cba8ba8c7..314bc007f379 100644 --- a/README.md +++ b/README.md @@ -162,7 +162,7 @@ They require JetPack 4.2 and above, and [@dusty-nv](https://github.com/dusty-nv) If you are installing from source, you will need: - Python 3.9 or later - A compiler that fully supports C++17, such as clang or gcc (gcc 9.4.0 or newer is required, on Linux) -- Visual Studio or Visual Studio Build Tool on Windows +- Visual Studio or Visual Studio Build Tool (Windows only) \* PyTorch CI uses Visual C++ BuildTools, which come with Visual Studio Enterprise, Professional, or Community Editions. You can also install the build tools from