frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[ci] use lintrunner in CI"

Browse Source 
This reverts commit 4c3ee53522ab8f71749b9f1412bea523f7b04304.

Reverted https://github.com/pytorch/pytorch/pull/68460 on behalf of https://github.com/malfet
This commit is contained in:
PyTorch MergeBot
2022-04-14 23:27:27 +00:00
parent 9bbe1d632e
commit db6165215e
7 changed files with 468 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
Makefile
View File

@ -1,6 +1,5 @@
# This makefile does nothing but delegating the actual building to cmake.
PYTHON = python3
PIP = pip3
all:
@mkdir -p build && cd build && cmake .. $(shell $(PYTHON) ./scripts/get_python_cmake_flags.py) && $(MAKE)
@ -52,7 +51,12 @@ shellcheck:
--job 'shellcheck'
setup_lint:
$(PIP) install lintrunner
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
--job 'flake8-py3' --step 'Install dependencies' --no-quiet
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
--job 'cmakelint' --step 'Install dependencies' --no-quiet
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
--job 'mypy' --step 'Install dependencies' --no-quiet
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
--job 'shellcheck' --step 'Install Jinja2' --no-quiet
@ -67,6 +71,8 @@ setup_lint:
--job 'shellcheck' --step 'Install ShellCheck' --no-quiet; \
fi
$(PYTHON) -mpip install jinja2 --user
$(PYTHON) -mpip install -r tools/linter/clang_tidy/requirements.txt --user
$(PYTHON) -m tools.linter.install.clang_tidy
quick_checks:
# TODO: This is broken when 'git config submodule.recurse' is 'true' since the
@ -74,7 +80,41 @@ quick_checks:
@$(PYTHON) tools/actions_local_runner.py \
--file .github/workflows/lint.yml \
--job 'quick-checks' \
--step 'Ensure no versionless Python shebangs'
--step 'Ensure no trailing spaces' \
--step 'Ensure no tabs' \
--step 'Ensure no non-breaking spaces' \
--step 'Ensure canonical include' \
--step 'Ensure no versionless Python shebangs' \
--step 'Ensure no unqualified noqa' \
--step 'Ensure GitHub PyPi dependencies are pinned' \
--step 'Ensure no unqualified type ignore' \
--step 'Ensure no direct cub include' \
--step 'Ensure correct trailing newlines' \
--step 'Ensure no raw cuda api calls'
flake8:
@$(PYTHON) tools/actions_local_runner.py \
$(CHANGED_ONLY) \
$(REF_BRANCH) \
--job 'flake8-py3'
mypy:
@$(PYTHON) tools/actions_local_runner.py \
$(CHANGED_ONLY) \
$(REF_BRANCH) \
--job 'mypy'
cmakelint:
@$(PYTHON) tools/actions_local_runner.py \
--file .github/workflows/lint.yml \
--job 'cmakelint' \
--step 'Run cmakelint'
clang-tidy:
@$(PYTHON) tools/actions_local_runner.py \
$(CHANGED_ONLY) \
$(REF_BRANCH) \
--job 'clang-tidy'
toc:
@$(PYTHON) tools/actions_local_runner.py \
@ -82,9 +122,7 @@ toc:
--job 'toc' \
--step "Regenerate ToCs and check that they didn't change"
lint: quick_checks shellcheck
lintrunner
lint: flake8 mypy quick_checks cmakelint shellcheck
quicklint: CHANGED_ONLY=--changed-only
quicklint: quick_checks shellcheck
lintrunner
quicklint: mypy flake8 quick_checks cmakelint shellcheck clang-tidy