From d89d21311842bfdc7b28bd81badf79f55b58b12e Mon Sep 17 00:00:00 2001 From: Alexander Grund Date: Fri, 30 May 2025 19:18:39 +0000 Subject: [PATCH] Fix test_tensorboard when started w/o tensorboard package (#154709) If `TEST_TENSORBOARD == False` then `DataType` is not defined or imported. However it is used unconditionally when defining the test with `parametrize` which leads to an NameError crashing the test execution on start. Provide a Dummy to make it syntactially correct. Tests will be skipped on start. ``` File "/dev/shm/build/pytorch-v2.2.1/test/test_tensorboard.py", line 885, in class TestTensorProtoSummary(BaseTestCase): File "/dev/shm/build/pytorch-v2.2.1/test/test_tensorboard.py", line 889, in TestTensorProtoSummary (torch.float16, DataType.DT_HALF), ^^^^^^^^ NameError: name 'DataType' is not defined Got exit code 1, retrying... test_tensorboard 1/1 failed! [Errno 2] No such file or directory: '/dev/shm/build/pytorch-v2.2.1/.pytest_cache/v/cache/stepcurrent/test_tensorboard_0_0dba8bc00bbe233f' ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/154709 Approved by: https://github.com/Skylion007 --- test/test_tensorboard.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_tensorboard.py b/test/test_tensorboard.py index a7f99f5c4594..c6982d319d81 100644 --- a/test/test_tensorboard.py +++ b/test/test_tensorboard.py @@ -122,6 +122,10 @@ if TEST_TENSORBOARD: from torch.utils.tensorboard._pytorch_graph import graph from torch.utils.tensorboard._utils import _prepare_video, convert_to_HWC from torch.utils.tensorboard.summary import int_to_half, tensor_proto +else: + # Dummy for parametrization + class DataType: + DT_FLOAT, DT_HALF, DT_BFLOAT16, DT_INT32 = [None] * 4 class TestTensorBoardPyTorchNumpy(BaseTestCase):