frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE][CI] bump ruff to 0.9.2: multiline assert statements (#144546)

Browse Source 
Reference: https://docs.astral.sh/ruff/formatter/black/#assert-statements

> Unlike Black, Ruff prefers breaking the message over breaking the assertion, similar to how both Ruff and Black prefer breaking the assignment value over breaking the assignment target:
>
> ```python
> # Input
> assert (
>     len(policy_types) >= priority + num_duplicates
> ), f"This tests needs at least {priority+num_duplicates} many types."
>
>
> # Black
> assert (
>     len(policy_types) >= priority + num_duplicates
> ), f"This tests needs at least {priority+num_duplicates} many types."
>
> # Ruff
> assert len(policy_types) >= priority + num_duplicates, (
>     f"This tests needs at least {priority + num_duplicates} many types."
> )
> ```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/144546
Approved by: https://github.com/malfet
This commit is contained in:
Xuehai Pan
2025-02-27 22:43:26 +08:00
committed by PyTorch MergeBot
parent f0d00421cf
commit c73a92fbf5
84 changed files with 634 additions and 622 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/run_test.py
View File

@ -1442,9 +1442,9 @@ def get_pytest_args(options, is_cpp_test=False, is_distributed_test=False):
def run_ci_sanity_check(test: ShardedTest, test_directory, options):
assert (
test.name == "test_ci_sanity_check_fail"
), f"This handler only works for test_ci_sanity_check_fail, got {test.name}"
assert test.name == "test_ci_sanity_check_fail", (
f"This handler only works for test_ci_sanity_check_fail, got {test.name}"
)
ret_code = run_test(test, test_directory, options, print_log=False)
# This test should fail
if ret_code != 1:
@ -1957,9 +1957,9 @@ def get_sharding_opts(options) -> tuple[int, int]:
assert len(options.shard) == 2, "Unexpected shard format"
assert min(options.shard) > 0, "Shards must be positive numbers"
which_shard, num_shards = options.shard
assert (
which_shard <= num_shards
), "Selected shard must be less than or equal to total number of shards"
assert which_shard <= num_shards, (
"Selected shard must be less than or equal to total number of shards"
)
return (which_shard, num_shards)
@ -2002,9 +2002,9 @@ def run_test_module(
print_to_stderr(f"Running {str(test)} ... [{datetime.now()}]")
handler = CUSTOM_HANDLERS.get(test_name, run_test)
return_code = handler(test, test_directory, options)
assert isinstance(return_code, int) and not isinstance(
return_code, bool
), f"While running {str(test)} got non integer return code {return_code}"
assert isinstance(return_code, int) and not isinstance(return_code, bool), (
f"While running {str(test)} got non integer return code {return_code}"
)
if return_code == 0:
return None