mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 21:14:14 +08:00
Update commitlist.py instructions for the GitHub repo regime (#149535)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/149535 Approved by: https://github.com/albanD
This commit is contained in:
committed by
PyTorch MergeBot
parent
76994d48f4
commit
c0618a3957
@ -32,6 +32,9 @@ Update the existing commitlist to commit bfcb687b9c.
|
||||
|
||||
"""
|
||||
|
||||
# Increase the allowed size of a CSV field to 1mil bytes for long files changed
|
||||
csv.field_size_limit(1000000)
|
||||
|
||||
|
||||
@dataclasses.dataclass(frozen=False)
|
||||
class Commit:
|
||||
@ -490,15 +493,15 @@ def get_markdown_header(category):
|
||||
header = f"""
|
||||
# Release Notes worksheet {category}
|
||||
|
||||
The main goal of this process is to rephrase all the commit messages below to make them clear and easy to read by the end user. You should follow the following instructions to do so:
|
||||
The main goal of this process is to rephrase all the commit messages below to make them **clear and easy to read** by the end user. You should follow the following instructions to do so:
|
||||
|
||||
* **Please cleanup, and format commit titles to be readable by the general pytorch user.** [Detailed instructions here](https://docs.google.com/document/d/14OmgGBr1w6gl1VO47GGGdwrIaUNr92DFhQbY_NEk8mQ/edit)
|
||||
* **Please clean up and format commit titles to be readable by the general PyTorch user.** Make sure you're [following the guidance here](https://docs.google.com/document/d/14OmgGBr1w6gl1VO47GGGdwrIaUNr92DFhQbY_NEk8mQ/edit)! Your resulting notes must be consistent and easy to read.
|
||||
* Please sort commits into the following categories (you should not rename the categories!), I tried to pre-sort these to ease your work, feel free to move commits around if the current categorization is not good.
|
||||
* Please drop any commits that are not user-facing.
|
||||
* If anything is from another domain, leave it in the UNTOPICED section at the end and I'll come and take care of it.
|
||||
* Please use markdown format
|
||||
* Please use #PR_NUM to link to the PR, instead of `[#PR_NUM](https://github.com/pytorch/pytorch/pull/#PR_NUM)` to reduce the length of the release notes
|
||||
* We place a lot of emphasis on the “BC-breaking” and “deprecation” sections. Those should be where the most effort goes in. The “improvements” and “bug fixes” for Python API should be nice as well. Everything else doesn’t matter too much so feel free to cut corners if time is short.
|
||||
* Anything that is not public facing needs to be removed.
|
||||
* If anything is miscategorized/belongs to another domain, move it to `miscategorized.md`.
|
||||
* Please scan through `miscategorized.md` and handle any commits that belong within your domain according to these instructions.
|
||||
* We place a lot of emphasis on the “BC-breaking” and “deprecation” sections. Those should be where the most effort goes in. The “improvements” and “bug fixes” for Python API should be nice as well.
|
||||
* Once you are finished, move this very file from `todo/` to `done/` and submit a pull request.
|
||||
|
||||
The categories below are as follows:
|
||||
|
||||
@ -510,6 +513,7 @@ The categories below are as follows:
|
||||
* performance: All commits that are added mainly for performance (we separate this from improvements above to make it easier for users to look for it)
|
||||
* documentation: All commits that add/update documentation
|
||||
* Developers: All commits that are not end-user facing but still impact people that compile from source, develop into pytorch, extend pytorch, etc
|
||||
* not user facing: All commits that are not public end-user facing and hence should be dropped from the release notes
|
||||
"""
|
||||
|
||||
return [header]
|
||||
|
Reference in New Issue
Block a user