Enable clang-tidy on c10/util/Float8*.h (#120573)

This PR clears warnings and enables clang-tidy on c10/util/Float8*.h.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/120573
Approved by: https://github.com/drisspg
This commit is contained in:
cyy
2024-06-14 13:47:07 +00:00
committed by PyTorch MergeBot
parent 1f46284f9e
commit bfd5ea93e0
7 changed files with 6 additions and 16 deletions

View File

@ -216,7 +216,6 @@ exclude_patterns = [
'c10/util/complex_math.h',
'c10/util/complex_utils.h',
'c10/util/flat_hash_map.h',
'c10/util/Float8*.h',
'c10/util/logging*.h',
'c10/util/hash.h',
'c10/util/strong_type.h',

View File

@ -1,7 +1,7 @@
#pragma once
#include <c10/macros/Macros.h>
#include <cstring>
#include <cstdint>
#include <limits>
C10_CLANG_DIAGNOSTIC_PUSH()

View File

@ -15,9 +15,7 @@
/// and inspired by Half implementation from pytorch/c10/util/Half.h
#include <c10/macros/Macros.h>
#include <c10/util/TypeSafeSignMath.h>
#include <c10/util/floating_point_utils.h>
#include <type_traits>
#if defined(__cplusplus)
#include <cmath>
@ -32,16 +30,7 @@
#endif
#include <climits>
#include <cstdint>
#include <cstring>
#include <iosfwd>
#include <limits>
#include <sstream>
#include <stdexcept>
#include <string>
#include <utility>
#include <typeinfo> // operator typeid
#include <iostream>
namespace c10 {

View File

@ -1,3 +1,4 @@
#include <c10/macros/Macros.h>
#include <c10/util/Float8_e4m3fnuz.h>
namespace c10 {

View File

@ -17,8 +17,8 @@
/// Implementation based on the paper https://arxiv.org/pdf/2206.02915.pdf and
/// the existing Float8_e4m3fn implementation.
#include <c10/macros/Export.h>
#include <c10/macros/Macros.h>
#include <c10/util/TypeSafeSignMath.h>
#include <c10/util/floating_point_utils.h>
#include <type_traits>

View File

@ -3,7 +3,7 @@
namespace c10 {
static_assert(
std::is_standard_layout<Float8_e5m2>::value,
std::is_standard_layout_v<Float8_e5m2>,
"c10::Float8_e5m2 must be standard layout.");
} // namespace c10

View File

@ -1,3 +1,4 @@
#include <c10/macros/Macros.h>
#include <c10/util/Float8_e5m2fnuz.h>
namespace c10 {