require that TARGET_DET_LIST is sorted (and sort it here) (#64102)

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/64102

We sort this list so that we may add comments to indicate the absence
of a file right where that file would need to be put. This makes it
difficult to wrongly add such a file.

The sorting itself was done programmatically to ensure that no entries
were inadvertently removed.

I printed the sorted list with:

```
  for p in sorted(TARGET_DET_LIST):
    print(f'    "{p}",')
```

Then copied it back into the file.

Test Plan: Imported from OSS

Reviewed By: driazati

Differential Revision: D30625076

Pulled By: dagitses

fbshipit-source-id: cf36fcb3e53e274b76d1f4aae83da1f53c03f9ed

test/test_determination.py

@@ -33,6 +33,13 @@ class DeterminationTest(unittest.TestCase):
             if run_test.should_run_test(run_test.TARGET_DET_LIST, test, changed_files, DummyOptions())
         ]
 
+    def test_target_det_list_is_sorted(self):
+        # We keep TARGET_DET_LIST sorted to minimize merge conflicts
+        # but most importantly to allow us to comment on the absence
+        # of a test. It would be very difficult to add a file right
+        # next to a comment that says to keep it out of the list.
+        self.assertListEqual(run_test.TARGET_DET_LIST, sorted(run_test.TARGET_DET_LIST))
+
     def test_config_change_only(self):
         """CI configs trigger all tests"""
         self.assertEqual(

tools/testing/modulefinder_determinator.py

@@ -12,50 +12,8 @@ REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent.parent
 # run with --determine-from, we use another generated list based on this one and the
 # previous test stats.
 TARGET_DET_LIST = [
-    "distributions/test_distributions",
-    "test_nn",
-    "test_autograd",
-    "test_cpp_extensions_jit",
-    "test_jit_legacy",
-    "test_dataloader",
-    "test_overrides",
-    "test_linalg",
-    "test_jit",
-    "test_jit_profiling",
-    "test_torch",
-    "test_binary_ufuncs",
-    "test_numpy_interop",
-    "test_reductions",
-    "test_shape_ops",
-    "test_sort_and_select",
-    "test_testing",
-    "test_view_ops",
-    "distributed/nn/jit/test_instantiator",
-    "distributed/rpc/test_tensorpipe_agent",
-    "distributed/rpc/cuda/test_tensorpipe_agent",
     "distributed/algorithms/ddp_comm_hooks/test_ddp_hooks",
-    "distributed/test_distributed_spawn",
-    "test_cuda",
-    "test_cuda_primary_ctx",
-    "test_cpp_extensions_aot_ninja",
-    "test_cpp_extensions_aot_no_ninja",
-    "test_serialization",
-    "test_optim",
-    "test_utils",
-    "test_multiprocessing",
-    "test_tensorboard",
-    "distributed/test_c10d_common",
-    "distributed/test_c10d_gloo",
-    "distributed/test_c10d_nccl",
-    "distributed/test_jit_c10d",
-    "distributed/test_c10d_spawn_gloo",
-    "distributed/test_c10d_spawn_nccl",
-    "distributed/test_store",
-    "distributed/test_pg_wrapper",
-    "test_quantization",
-    "test_pruning_op",
-    "test_determination",
-    "test_futures",
+    "distributed/nn/jit/test_instantiator",
     "distributed/pipeline/sync/skip/test_api",
     "distributed/pipeline/sync/skip/test_gpipe",
     "distributed/pipeline/sync/skip/test_inspect_skip_layout",
@@ -78,8 +36,51 @@ TARGET_DET_LIST = [
     "distributed/pipeline/sync/test_stream",
     "distributed/pipeline/sync/test_transparency",
     "distributed/pipeline/sync/test_worker",
+    "distributed/rpc/cuda/test_tensorpipe_agent",
+    "distributed/rpc/test_tensorpipe_agent",
+    "distributed/test_c10d_common",
+    "distributed/test_c10d_gloo",
+    "distributed/test_c10d_nccl",
+    "distributed/test_c10d_spawn_gloo",
+    "distributed/test_c10d_spawn_nccl",
+    "distributed/test_distributed_spawn",
+    "distributed/test_jit_c10d",
+    "distributed/test_pg_wrapper",
+    "distributed/test_store",
+    "distributions/test_distributions",
+    "test_autograd",
+    "test_binary_ufuncs",
+    "test_cpp_extensions_aot_ninja",
+    "test_cpp_extensions_aot_no_ninja",
+    "test_cpp_extensions_jit",
+    "test_cuda",
+    "test_cuda_primary_ctx",
+    "test_dataloader",
+    "test_determination",
+    "test_futures",
+    "test_jit",
+    "test_jit_legacy",
+    "test_jit_profiling",
+    "test_linalg",
+    "test_multiprocessing",
+    "test_nn",
+    "test_numpy_interop",
+    "test_optim",
+    "test_overrides",
+    "test_pruning_op",
+    "test_quantization",
+    "test_reductions",
+    "test_serialization",
+    "test_shape_ops",
+    "test_sort_and_select",
+    "test_tensorboard",
+    "test_testing",
+    "test_torch",
+    "test_utils",
+    "test_view_ops",
 ]
 
+
 _DEP_MODULES_CACHE: Dict[str, Set[str]] = {}