frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[caffe2][SDT] Check whether TORCH_DISABLE_SDT macro is defined before referencing it (#107149)

Browse Source 
Summary:
Some jobs in the next diff in stack (D48229150) fail with the following message:

```
stderr: In file included from xplat/caffe2/c10/cuda/CUDACachingAllocator.cpp:9:
xplat/caffe2/c10/util/static_tracepoint.h:4:6: error: 'TORCH_DISABLE_SDT' is not defined, evaluates to 0 [-Werror,-Wundef]
    !TORCH_DISABLE_SDT
```

When porting USDT macros to PyTorch in D47159249, I must have not hit a codepath which treated warnings as errors during testing.

This diff fixes the issue by first checking whether the `TORCH_DISABLE_SDT` macro is defined before trying to access it in the `static_tracepoint.h` header.

Test Plan:
Similar to D47159249, tested the following macro on test scripts with `libbpf` USDTs:
* `CAFFE_DISABLE_SDT`

Reviewed By: chaekit

Differential Revision: D48251736

Pull Request resolved: https://github.com/pytorch/pytorch/pull/107149
Approved by: https://github.com/chaekit
This commit is contained in:
v-s-2
2023-08-16 19:52:12 +00:00
committed by PyTorch MergeBot
parent f16be5e0d4
commit ba6fcc4eae
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
c10/util/static_tracepoint.h
View File

@ -1,7 +1,7 @@
#pragma once
#if defined(__ELF__) && (defined(__x86_64__) || defined(__i386__)) && \
!TORCH_DISABLE_SDT
!(defined(TORCH_DISABLE_SDT) && TORCH_DISABLE_SDT)
#define TORCH_HAVE_SDT 1