frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[AOTI] raise PyTorchStreamWriter open failed error code on windows (#162799)

Browse Source 
When I debug AOTI UT: `TestAOTInductorPackage_cpu::test_add`.  I found it didn't output the verbose error code, when PyTorchStreamWriter open failed.

This PR add the verbose error code output for debug. Local test shows as below:
<img width="1124" height="653" alt="image" src="https://github.com/user-attachments/assets/01cb1a51-2982-4106-8b5b-c608ac26a075" />

The error code is 32, we can check the Windows error code 32 at https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
```
ERROR_SHARING_VIOLATION
32 (0x20)
The process cannot access the file because it is being used by another process.
```

This issue is caused by the file is opened by another process. I fixed same issue in zip open as PR: https://github.com/pytorch/pytorch/pull/162617 But still no idea how to open file with shared access in `std::ofstream`. I will continue to researching it.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/162799
Approved by: https://github.com/jansel
This commit is contained in:
Xu Han
2025-09-13 01:41:14 +00:00
committed by PyTorch MergeBot
parent a749c40342
commit b2553a6ec4
1 changed files with 31 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
caffe2/serialize/inline_container.cc
View File

@ -27,6 +27,10 @@
#include "caffe2/serialize/versions.h" #include "caffe2/serialize/versions.h"
#include "miniz.h" #include "miniz.h"
#ifdef _WIN32
#include <Windows.h>
#endif // _WIN32
namespace caffe2 { namespace caffe2 {
namespace serialize { namespace serialize {
constexpr std::string_view kDebugPklSuffix(".debug_pkl"); constexpr std::string_view kDebugPklSuffix(".debug_pkl");
@ -711,21 +715,35 @@ void PyTorchStreamWriter::setup(const string& file_name) {
if (archive_name_.size() == 0) { if (archive_name_.size() == 0) {
CAFFE_THROW("invalid file name: ", file_name); CAFFE_THROW("invalid file name: ", file_name);
} }
if (!writer_func_) {
file_stream_.open(
file_name,
std::ofstream::out | std::ofstream::trunc | std::ofstream::binary);
valid("opening archive ", file_name.c_str());
const std::string dir_name = parentdir(file_name); const std::string dir_name = parentdir(file_name);
if (!dir_name.empty()) { if (!dir_name.empty()) {
struct stat st; struct stat st;
bool dir_exists = bool dir_exists =
(stat(dir_name.c_str(), &st) == 0 && (st.st_mode & S_IFDIR)); (stat(dir_name.c_str(), &st) == 0 && (st.st_mode & S_IFDIR));
TORCH_CHECK( TORCH_CHECK(
dir_exists, "Parent directory ", dir_name, " does not exist."); dir_exists, "Parent directory ", dir_name, " does not exist.");
}
TORCH_CHECK(file_stream_, "File ", file_name, " cannot be opened.");
if (!writer_func_) {
valid("opening archive ", file_name.c_str());
try {
file_stream_.exceptions(std::ios_base::failbit | std::ios_base::badbit);
file_stream_.open(
file_name,
std::ofstream::out | std::ofstream::trunc | std::ofstream::binary
);
} catch (const std::ios_base::failure& e) {
#ifdef _WIN32
// Windows have verbose error code, we prefer to use it than std errno.
uint32_t error_code = GetLastError();
CAFFE_THROW("open file failed with error code: ", error_code);
#else // !_WIN32
CAFFE_THROW("open file failed with strerror: ", strerror(errno));
#endif // _WIN32
} }
TORCH_CHECK(file_stream_, "File ", file_name, " cannot be opened.");
writer_func_ = [this](const void* buf, size_t nbytes) -> size_t { writer_func_ = [this](const void* buf, size_t nbytes) -> size_t {
if (!buf) { if (!buf) {
// See [Note: write_record_metadata] // See [Note: write_record_metadata]