frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix buck OSS build after #115570 (#115804)

Browse Source 
From #115570, `supports_shlib_interfaces` is only available in https://buck2.build/docs/api/rules/ not buck https://buck.build/rule/cxx_library.html.  The best way to fix this is probably to migrate OSS CI to buck2, so this is a temporary workaround because the fix from #115570 is only needed internally anyway
Pull Request resolved: https://github.com/pytorch/pytorch/pull/115804
Approved by: https://github.com/kit1980, https://github.com/malfet
This commit is contained in:
Huy Do
2023-12-14 08:33:07 +00:00
committed by PyTorch MergeBot
parent adfbd2b219
commit afe6d272c6
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/build_defs/buck_helpers.bzl
View File

@ -14,12 +14,19 @@ IGNORED_ATTRIBUTES = [
"contacts",
]
# TODO (huydhn): PyTorch OSS is still built with old buck not buck2, and there
# aren't available options https://buck.build/rule/cxx_library.html. This can
# be removed when we migrate OSS to buck2
ONLY_AVAILABLE_IN_BUCK2 = [
"supports_shlib_interfaces",
]
def filter_attributes(kwgs):
keys = list(kwgs.keys())
# drop unncessary attributes
for key in keys:
if key in IGNORED_ATTRIBUTES:
if key in IGNORED_ATTRIBUTES or key in ONLY_AVAILABLE_IN_BUCK2:
kwgs.pop(key)
else:
for invalid_prefix in IGNORED_ATTRIBUTE_PREFIX: