frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

12/n : Remove fbandroid_compiler_flags (#165558)

Browse Source 
Summary:
Currently `get_c2_fbandroid_xplat_compiler_flags()` is reading the `caffe2.strip_glog` buckconfig which we want to get rid of.
This diff removes the `fbandroid_compiler_flags` arg and merges it with compiler_flags with a nested select and the select version of the method

The goal is to get rid of all the usages of `get_c2_fbandroid_xplat_compiler_flags()` so that we can get rid of the `caffe2.strip_glog` buckconfig

Test Plan: CI

bifferential Revision: D84626885

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165558
Approved by: https://github.com/malfet
This commit is contained in:
Ketan Ambati
2025-10-16 20:41:21 +00:00
committed by PyTorch MergeBot
parent 9bf5b38c14
commit aead9270f5
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
buckbuild.bzl
View File

@ -1729,8 +1729,10 @@ def define_buck_targets(
"torch/csrc/jit/backends/backend_debug_info.cpp", "torch/csrc/jit/backends/backend_debug_info.cpp",
"torch/csrc/jit/backends/backend_interface.cpp", "torch/csrc/jit/backends/backend_interface.cpp",
], ],
compiler_flags = get_pt_compiler_flags(), compiler_flags = get_pt_compiler_flags() + select({
fbandroid_compiler_flags = c2_fbandroid_xplat_compiler_flags, "DEFAULT": [],
"ovr_config//os:android": c2_fbandroid_xplat_compiler_flags
}),
# @lint-ignore BUCKLINT link_whole # @lint-ignore BUCKLINT link_whole
link_whole = True, link_whole = True,
linker_flags = get_no_as_needed_linker_flag(), linker_flags = get_no_as_needed_linker_flag(),
@ -2023,6 +2025,9 @@ def define_buck_targets(
"ovr_config//os:android-x86_64": [ "ovr_config//os:android-x86_64": [
"-mssse3", "-mssse3",
], ],
}) + select({
"DEFAULT": [],
"ovr_config//os:android": c2_fbandroid_xplat_compiler_flags,
}), }),
exported_preprocessor_flags = get_aten_preprocessor_flags(), exported_preprocessor_flags = get_aten_preprocessor_flags(),
exported_deps = [ exported_deps = [