From aaefa484417a84a2f5cfcfe4d5041b596c074b4c Mon Sep 17 00:00:00 2001 From: Laith Sakka Date: Wed, 13 Nov 2024 14:11:01 -0800 Subject: [PATCH] reduce the threshold to change exisiting data suggestion to noise/3 (#140623) Pull Request resolved: https://github.com/pytorch/pytorch/pull/140623 Approved by: https://github.com/bobrenjc93 --- benchmarks/dynamo/pr_time_benchmarks/check_results.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/benchmarks/dynamo/pr_time_benchmarks/check_results.py b/benchmarks/dynamo/pr_time_benchmarks/check_results.py index 8b18af47a589..0d75221c8aff 100644 --- a/benchmarks/dynamo/pr_time_benchmarks/check_results.py +++ b/benchmarks/dynamo/pr_time_benchmarks/check_results.py @@ -132,10 +132,10 @@ def main(): ) new_entry = copy.deepcopy(entry) - # only change if abs(ratio) > entry.noise_margin /4. + # only change if abs(ratio) > entry.noise_margin /3. new_entry.expected_value = ( replace_with_zeros(result) - if abs(ratio) > entry.noise_margin / 4 + if abs(ratio) > entry.noise_margin / 3 else entry.expected_value ) new_expected[key] = new_entry