frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-28 10:34:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable avoid-non-const-global-variables lint check (#62008)

Browse Source 
Summary:
As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH`

All changes but the ones to `.clang-tidy` are generated using following script:
```
for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`;  do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/62008

Reviewed By: driazati, r-barnes

Differential Revision: D29838584

Pulled By: malfet

fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
This commit is contained in:
Nikita Shulga
2021-07-22 18:00:38 -07:00
committed by Facebook GitHub Bot
parent 260198d42c
commit a9b0a921d5
1011 changed files with 1 additions and 7626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
torch/csrc/jit/python/python_ir.h
View File

@ -13,7 +13,6 @@ void initPythonIRBindings(PyObject* module);
// execute a Python function, used for Ops we can't optimize but that we want to
// optimize around
struct ConcretePythonOp : public PythonOp {
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
static Symbol Kind;
ConcretePythonOp(Graph* graph) : PythonOp(graph, ::c10::prim::PythonOp) {}