frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-21 05:34:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable avoid-non-const-global-variables lint check (#62008)

Browse Source 
Summary:
As GoogleTest `TEST` macro is non-compliant with it as well as `DEFINE_DISPATCH`

All changes but the ones to `.clang-tidy` are generated using following script:
```
for i in `find . -type f -iname "*.c*" -or -iname "*.h"|xargs grep cppcoreguidelines-avoid-non-const-global-variables|cut -f1 -d:|sort|uniq`;  do sed -i "/\/\/ NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)/d" $i; done
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/62008

Reviewed By: driazati, r-barnes

Differential Revision: D29838584

Pulled By: malfet

fbshipit-source-id: 1b2f8602c945bd4ce50a9bfdd204755556e31d13
This commit is contained in:
Nikita Shulga
2021-07-22 18:00:38 -07:00
committed by Facebook GitHub Bot
parent 260198d42c
commit a9b0a921d5
1011 changed files with 1 additions and 7626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
torch/csrc/distributed/rpc/rref_context.cpp
View File

@ -9,9 +9,7 @@ namespace distributed {
namespace rpc {
thread_local std::vector<std::shared_ptr<RRefContext::PendingUserState>>
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
RRefContext::userTable_;
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
thread_local bool RRefContext::recording_ = false;
namespace callback {
@ -84,7 +82,6 @@ const std::string kNumForks = "num_forks";
RRefContext& RRefContext::getInstance() {
// Leaky singleton to avoid module destructor races.
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
static RRefContext* context = new RRefContext(RpcAgent::getCurrentRpcAgent());
return *context;
}