frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix CheckOutputStreamSetting on JitLoggingTest as it failed if logging wasn't enabled. (#82722)

Browse Source 
`JIT_LOG` checks if logging was enabled for that particular file and when it isn't it doesn't output anything. Since the test checks for the size of `test_stream` it fails. I believe forcing the file to have logging enabled to see if the stream is being correctly set during test makes no sense so this patches just forcibly outputs and checks if it worked.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/82722
Approved by: https://github.com/davidberard98
This commit is contained in:
Everton Constantino
2022-11-23 22:46:29 +00:00
committed by PyTorch MergeBot
parent b8d3afd886
commit a00efe55c3
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/cpp/jit/test_jit_logging_levels.cpp
View File

@ -41,7 +41,15 @@ TEST(JitLoggingTest, CheckOutputStreamSetting) {
::torch::jit::set_jit_logging_levels("test_jit_logging_levels");
std::ostringstream test_stream;
::torch::jit::set_jit_logging_output_stream(test_stream);
JIT_LOG(::torch::jit::JitLoggingLevels::GRAPH_DUMP, "Message");
/* Using JIT_LOG checks if this file has logging enabled with
is_enabled(__FILE__, level) making the test fail. since we are only testing
the OutputStreamSetting we can forcefully output to it directly.
*/
::torch::jit::get_jit_logging_output_stream() << ::torch::jit::jit_log_prefix(
::torch::jit::JitLoggingLevels::GRAPH_DUMP,
__FILE__,
__LINE__,
::c10::str("Message"));
ASSERT_TRUE(test_stream.str().size() > 0);
}