frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[CMake] Remove forcing of -O2 from torch_compile_options (#164894)

Browse Source 
That was introduced by 75a65ffe0f
Hattip to @jathu for alerting me about the issue. As result, all our PyTorch builds were shipped with `-O2` for almost all of its modern history

Partially undo the damage introduced by https://github.com/pytorch/pytorch/pull/128406 that cause cross-ISA symbols leak, to be properly followed up in https://github.com/pytorch/pytorch/issues/165123

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164894
Approved by: https://github.com/ezyang
This commit is contained in:
Nikita Shulga
2025-10-09 18:23:18 -07:00
committed by PyTorch MergeBot
parent df514a6d5a
commit 9a3c4b917e
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmake/public/utils.cmake
View File

@ -439,10 +439,6 @@ function(torch_compile_options libname)
$<$<COMPILE_LANGUAGE:CXX>: -fvisibility=hidden>)
endif()
# Use -O2 for release builds (-O3 doesn't improve perf, and -Os results in perf regression)
target_compile_options(${libname} PRIVATE
$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<OR:$<CONFIG:Release>,$<CONFIG:RelWithDebInfo>>>:-O2>)
endfunction()
##############################################################################
@ -530,4 +526,4 @@ function(target_link_options_if_supported tgt flag)
else()
message(WARNING "Attempted to use unsupported link option : ${flag}.")
endif()
endfunction()
endfunction()