mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
[release] delete tag-docker-images.sh as not required anymore (#156737)
Thanks to @clee2000 This is no longer required since the docker images use hash as tag: https://github.com/pytorch/pytorch/actions/runs/15844298044/job/44662813176#step:15:92 ``` Login Succeeded ++ docker manifest inspect docker.io/pytorch/manylinux2_28-builder:cuda12.9-5011468da53e13424002bd211cc919a0ec0e8b09 ++ jq '[.layers[].size, .config.size] | add / 1024 / 1024' + IMAGE_SIZE=9322.26076889038 + echo 'Compressed size of image in MB: 9322.26076889038' + set -e + docker inspect --type=image docker.io/pytorch/manylinux2_28-builder:cuda12.9-5011468da53e13424002bd211cc919a0ec0e8b09 Compressed size of image in MB: 9322.26076[88](https://github.com/pytorch/pytorch/actions/runs/15844298044/job/44662813176#step:15:90)9038 + retry docker pull docker.io/pytorch/manylinux2_28-builder:cuda12.9-5011468da53e13424002bd211cc919a0ec0e8b09 + docker pull docker.io/pytorch/manylinux2_28-builder:cuda12.9-5011468da53e13424002bd211cc919a0ec0e8b09 cuda12.9-5011468da53e13424002bd211cc919a0ec0e8b09: Pulling from pytorch/manylinux2_28-builder ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/156737 Approved by: https://github.com/clee2000
This commit is contained in:
committed by
PyTorch MergeBot
parent
029e2b05c2
commit
8eb3c5b7a1
64
.github/scripts/tag_docker_images_for_release.py
vendored
64
.github/scripts/tag_docker_images_for_release.py
vendored
@ -1,64 +0,0 @@
|
||||
import argparse
|
||||
import subprocess
|
||||
|
||||
import generate_binary_build_matrix
|
||||
|
||||
|
||||
def tag_image(
|
||||
image: str,
|
||||
default_tag: str,
|
||||
release_version: str,
|
||||
dry_run: str,
|
||||
tagged_images: dict[str, bool],
|
||||
) -> None:
|
||||
if image in tagged_images:
|
||||
return
|
||||
release_image = image.replace(f"-{default_tag}", f"-{release_version}")
|
||||
print(f"Tagging {image} to {release_image} , dry_run: {dry_run}")
|
||||
|
||||
if dry_run == "disabled":
|
||||
subprocess.check_call(["docker", "pull", image])
|
||||
subprocess.check_call(["docker", "tag", image, release_image])
|
||||
subprocess.check_call(["docker", "push", release_image])
|
||||
tagged_images[image] = True
|
||||
|
||||
|
||||
def main() -> None:
|
||||
parser = argparse.ArgumentParser()
|
||||
parser.add_argument(
|
||||
"--version",
|
||||
help="Version to tag",
|
||||
type=str,
|
||||
default="2.2",
|
||||
)
|
||||
parser.add_argument(
|
||||
"--dry-run",
|
||||
help="No Runtime Error check",
|
||||
type=str,
|
||||
choices=["enabled", "disabled"],
|
||||
default="enabled",
|
||||
)
|
||||
|
||||
options = parser.parse_args()
|
||||
tagged_images: dict[str, bool] = {}
|
||||
platform_images = [
|
||||
generate_binary_build_matrix.WHEEL_CONTAINER_IMAGES,
|
||||
generate_binary_build_matrix.LIBTORCH_CONTAINER_IMAGES,
|
||||
]
|
||||
default_tag = generate_binary_build_matrix.DEFAULT_TAG
|
||||
|
||||
for platform_image in platform_images: # type: ignore[attr-defined]
|
||||
for arch in platform_image.keys(): # type: ignore[attr-defined]
|
||||
if arch == "cpu-s390x":
|
||||
continue
|
||||
tag_image(
|
||||
platform_image[arch], # type: ignore[index]
|
||||
default_tag,
|
||||
options.version,
|
||||
options.dry_run,
|
||||
tagged_images,
|
||||
)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
@ -10,8 +10,7 @@ These are a collection of scripts that are to be used for release activities.
|
||||
### Order of Execution
|
||||
|
||||
1. Run cut-release-branch.sh to cut the release branch
|
||||
2. Run tag-docker-images.sh to tag current docker images with release tag and push them to docker.io. These images will be used to build the release.
|
||||
3. Run apply-release-changes.sh to apply release only changes to create a PR with release only changes similar to this [PR](https://github.com/pytorch/pytorch/pull/149056)
|
||||
2. Run apply-release-changes.sh to apply release only changes to create a PR with release only changes similar to this [PR](https://github.com/pytorch/pytorch/pull/149056)
|
||||
|
||||
#### Promoting packages
|
||||
|
||||
|
@ -1,24 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
#
|
||||
# Step 1 after branch cut is complete.
|
||||
#
|
||||
# Tags latest docker images for release branch.
|
||||
# In case of failure. The script can be rerun.
|
||||
#
|
||||
# Before executing this script do:
|
||||
# 1. Create and Check out to Release Branch
|
||||
# git checkout -b "${RELEASE_BRANCH}"
|
||||
# 2. Update submodules
|
||||
# git submodule update --init --recursive
|
||||
#
|
||||
# Usage (run from root of project):
|
||||
# DRY_RUN=disabled ./scripts/release/tag-docker-images.sh
|
||||
#
|
||||
|
||||
set -eou pipefail
|
||||
|
||||
GIT_TOP_DIR=$(git rev-parse --show-toplevel)
|
||||
RELEASE_VERSION=${RELEASE_VERSION:-$(cut -d'.' -f1-2 "${GIT_TOP_DIR}/version.txt")}
|
||||
DRY_RUN=${DRY_RUN:-enabled}
|
||||
|
||||
python3 .github/scripts/tag_docker_images_for_release.py --version ${RELEASE_VERSION} --dry-run ${DRY_RUN}
|
Reference in New Issue
Block a user