frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-21 21:49:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE]: Update ruff to 0.285 (#107519)

Browse Source 
This updates ruff to 0.285 which is faster, better, and have fixes a bunch of false negatives with regards to fstrings.

I also enabled RUF017 which looks for accidental quadratic list summation. Luckily, seems like there are no instances of it in our codebase, so enabling it so that it stays like that. :)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/107519
Approved by: https://github.com/ezyang
This commit is contained in:
Aaron Gokaslan
2023-08-20 01:36:14 +00:00
committed by PyTorch MergeBot
parent 02c2b750c5
commit 88ab3e4322
86 changed files with 319 additions and 403 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
torch/_namedtensor_internals.py
View File

@ -50,8 +50,8 @@ def single_ellipsis_index(names, fn_name):
ellipsis_indices = [i for i, name in enumerate(names) if is_ellipsis(name)]
if len(ellipsis_indices) >= 2:
raise RuntimeError(
"{}: More than one Ellipsis ('...') found in names ("
"{}). This function supports up to one Ellipsis.".format(fn_name, names)
f"{fn_name}: More than one Ellipsis ('...') found in names ("
f"{names}). This function supports up to one Ellipsis."
)
if len(ellipsis_indices) == 1:
return ellipsis_indices[0]
@ -97,15 +97,8 @@ def update_names_with_mapping(tensor, rename_map, inplace):
dim_map[old_dim] = new_dim
else:
raise RuntimeError(
(
"{api_name}: Tried to rename dim '{old_dim}' to dim "
"{new_dim} in Tensor[{dims}] but dim '{old_dim}' does not exist"
).format(
old_dim=old_dim,
new_dim=new_dim,
dims=tensor.names,
api_name=namer_api_name(inplace),
)
f"{namer_api_name(inplace)}: Tried to rename dim '{old_dim}' to dim "
f"{new_dim} in Tensor[{tensor.names}] but dim '{old_dim}' does not exist"
)
return tensor._update_names(tuple(dim_map.values()), inplace)
@ -149,10 +142,10 @@ def update_names(tensor, names, rename_map, inplace):
has_rename_pairs = bool(rename_map)
if has_names and has_rename_pairs:
raise RuntimeError(
"{api_name}: This function takes either positional "
"args or keyword args, but not both. Use tensor.{api_name}(*names) "
"to name dims and tensor.{api_name}(**rename_map) to rename "
"dims.".format(api_name=namer_api_name(inplace))
f"{namer_api_name(inplace)}: This function takes either positional "
f"args or keyword args, but not both. Use tensor.{namer_api_name(inplace)}(*names) "
f"to name dims and tensor.{namer_api_name(inplace)}(**rename_map) to rename "
"dims."
)
# Special case for tensor.rename(*[]), which is valid for a 0 dim tensor.