frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

increase clang-tidy coverage to more c10 source files (#102902)

Browse Source 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102902
Approved by: https://github.com/Skylion007
This commit is contained in:
cyy
2023-06-04 06:33:01 +00:00
committed by PyTorch MergeBot
parent 992bffe5a3
commit 87cbfe957a
16 changed files with 87 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
c10/util/signal_handler.cpp
View File

@ -112,6 +112,7 @@ FatalSignalHandler::FatalSignalHandler()
writingCond(PTHREAD_COND_INITIALIZER),
writingMutex(PTHREAD_MUTEX_INITIALIZER) {}
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
FatalSignalHandler::signal_handler FatalSignalHandler::kSignalHandlers[] = {
{"SIGABRT", SIGABRT, {}},
{"SIGINT", SIGINT, {}},
@ -159,7 +160,7 @@ void FatalSignalHandler::stacktraceSignalHandler(bool needsLock) {
if (needsLock) {
pthread_mutex_lock(&writingMutex);
}
pid_t tid = syscall(SYS_gettid);
pid_t tid = static_cast<pid_t>(syscall(SYS_gettid));
std::string backtrace = fmt::format(
"{}({}), PID: {}, Thread {}: \n {}",
fatalSignalName,
@ -201,7 +202,7 @@ void FatalSignalHandler::fatalSignalHandler(int signum) {
DIR* procDir = opendir("/proc/self/task");
if (procDir) {
pid_t pid = getpid();
pid_t currentTid = syscall(SYS_gettid);
pid_t currentTid = static_cast<pid_t>(syscall(SYS_gettid));
struct dirent* entry = nullptr;
pthread_mutex_lock(&writingMutex);
while ((entry = readdir(procDir)) != nullptr) {