frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE]: Enable RUF015 codebase wide (#115507)

Browse Source 
Constant time access of first value in collection. This is a constant time operation instead of converting the item to a list to get the first item which is linear. The rule is turned on which automatically autofixes and enforces this.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/115507
Approved by: https://github.com/malfet
This commit is contained in:
Aaron Gokaslan
2023-12-11 15:51:01 +00:00
committed by PyTorch MergeBot
parent 1e5636f791
commit 794545c11f
27 changed files with 86 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
test/test_weak.py
View File

@ -293,7 +293,7 @@ class WeakKeyDictionaryTestCase(TestCase):
# Indexing
for key, value in self.reference.items():
self.assertEqual(d[key], value)
knownkey = list(self.other.keys())[0]
knownkey = next(iter(self.other.keys()))
self.assertRaises(KeyError, lambda: d[knownkey])
# len
self.assertEqual(len(p), 0)
@ -389,8 +389,8 @@ class WeakKeyDictionaryTestCase(TestCase):
d = self._empty_mapping()
self.assertEqual(list(d.keys()), [])
d = self.reference
self.assertIn(list(self.inmapping.keys())[0], d.keys())
self.assertNotIn(list(self.other.keys())[0], d.keys())
self.assertIn(next(iter(self.inmapping.keys())), d.keys())
self.assertNotIn(next(iter(self.other.keys())), d.keys())
self.assertRaises(TypeError, d.keys, None)
def test_values(self):
@ -412,7 +412,7 @@ class WeakKeyDictionaryTestCase(TestCase):
def test_getitem(self):
d = self.reference
self.assertEqual(
d[list(self.inmapping.keys())[0]], list(self.inmapping.values())[0]
d[next(iter(self.inmapping.keys()))], next(iter(self.inmapping.values()))
)
self.assertRaises(TypeError, d.__getitem__)
@ -535,16 +535,18 @@ class WeakKeyDictionaryTestCase(TestCase):
def test_get(self):
d = self._empty_mapping()
self.assertTrue(d.get(list(self.other.keys())[0]) is None)
self.assertEqual(d.get(list(self.other.keys())[0], 3), 3)
self.assertTrue(d.get(next(iter(self.other.keys()))) is None)
self.assertEqual(d.get(next(iter(self.other.keys())), 3), 3)
d = self.reference
self.assertTrue(d.get(list(self.other.keys())[0]) is None)
self.assertEqual(d.get(list(self.other.keys())[0], 3), 3)
self.assertTrue(d.get(next(iter(self.other.keys()))) is None)
self.assertEqual(d.get(next(iter(self.other.keys())), 3), 3)
self.assertEqual(
d.get(list(self.inmapping.keys())[0]), list(self.inmapping.values())[0]
d.get(next(iter(self.inmapping.keys()))),
next(iter(self.inmapping.values())),
)
self.assertEqual(
d.get(list(self.inmapping.keys())[0], 3), list(self.inmapping.values())[0]
d.get(next(iter(self.inmapping.keys())), 3),
next(iter(self.inmapping.values())),
)
self.assertRaises(TypeError, d.get)
self.assertRaises(TypeError, d.get, None, None, None)
@ -560,9 +562,9 @@ class WeakKeyDictionaryTestCase(TestCase):
def test_pop(self):
d = self._empty_mapping()
k, v = list(self.inmapping.items())[0]
k, v = next(iter(self.inmapping.items()))
d[k] = v
self.assertRaises(KeyError, d.pop, list(self.other.keys())[0])
self.assertRaises(KeyError, d.pop, next(iter(self.other.keys())))
self.assertEqual(d.pop(k), v)
self.assertEqual(len(d), 0)
@ -632,7 +634,7 @@ class WeakKeyDictionaryScriptObjectTestCase(TestCase):
# Indexing
for key, value in self.reference.items():
self.assertEqual(d[key], value)
knownkey = list(self.other.keys())[0]
knownkey = next(iter(self.other.keys()))
self.assertRaises(KeyError, lambda: d[knownkey])
# len
self.assertEqual(len(p), 0)
@ -728,8 +730,8 @@ class WeakKeyDictionaryScriptObjectTestCase(TestCase):
d = self._empty_mapping()
self.assertEqual(list(d.keys()), [])
d = self.reference
self.assertIn(list(self.inmapping.keys())[0], d.keys())
self.assertNotIn(list(self.other.keys())[0], d.keys())
self.assertIn(next(iter(self.inmapping.keys())), d.keys())
self.assertNotIn(next(iter(self.other.keys())), d.keys())
self.assertRaises(TypeError, d.keys, None)
def test_values(self):
@ -751,7 +753,7 @@ class WeakKeyDictionaryScriptObjectTestCase(TestCase):
def test_getitem(self):
d = self.reference
self.assertEqual(
d[list(self.inmapping.keys())[0]], list(self.inmapping.values())[0]
d[next(iter(self.inmapping.keys()))], next(iter(self.inmapping.values()))
)
self.assertRaises(TypeError, d.__getitem__)
@ -874,16 +876,18 @@ class WeakKeyDictionaryScriptObjectTestCase(TestCase):
def test_get(self):
d = self._empty_mapping()
self.assertTrue(d.get(list(self.other.keys())[0]) is None)
self.assertEqual(d.get(list(self.other.keys())[0], 3), 3)
self.assertTrue(d.get(next(iter(self.other.keys()))) is None)
self.assertEqual(d.get(next(iter(self.other.keys())), 3), 3)
d = self.reference
self.assertTrue(d.get(list(self.other.keys())[0]) is None)
self.assertEqual(d.get(list(self.other.keys())[0], 3), 3)
self.assertTrue(d.get(next(iter(self.other.keys()))) is None)
self.assertEqual(d.get(next(iter(self.other.keys())), 3), 3)
self.assertEqual(
d.get(list(self.inmapping.keys())[0]), list(self.inmapping.values())[0]
d.get(next(iter(self.inmapping.keys()))),
next(iter(self.inmapping.values())),
)
self.assertEqual(
d.get(list(self.inmapping.keys())[0], 3), list(self.inmapping.values())[0]
d.get(next(iter(self.inmapping.keys())), 3),
next(iter(self.inmapping.values())),
)
self.assertRaises(TypeError, d.get)
self.assertRaises(TypeError, d.get, None, None, None)
@ -899,9 +903,9 @@ class WeakKeyDictionaryScriptObjectTestCase(TestCase):
def test_pop(self):
d = self._empty_mapping()
k, v = list(self.inmapping.items())[0]
k, v = next(iter(self.inmapping.items()))
d[k] = v
self.assertRaises(KeyError, d.pop, list(self.other.keys())[0])
self.assertRaises(KeyError, d.pop, next(iter(self.other.keys())))
self.assertEqual(d.pop(k), v)
self.assertEqual(len(d), 0)