frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-11-06 09:17:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use correct signatures for METH_NOARGS. (#45528)

Browse Source 
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/45528

As described in https://github.com/pytorch/pytorch/issues/45419,
resolving a bunch of cpython signature issues.

#Closes: https://github.com/pytorch/pytorch/issues/45419
ghstack-source-id: 113385726

Test Plan: sentinel

Reviewed By: albanD

Differential Revision: D24000626

fbshipit-source-id: d334596f1f0256063691aa044c8fb2face260817
This commit is contained in:
Pritam Damania
2020-10-02 10:41:55 -07:00
committed by Facebook GitHub Bot
parent cdf93b03de
commit 6e43f0db8b
6 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
torch/csrc/autograd/python_variable.cpp
View File

@ -388,19 +388,19 @@ PyObject *THPVariable_get_ndim(THPVariable *self, void *unused)
END_HANDLE_TH_ERRORS
}
PyObject *THPVariable_get_names(THPVariable *self, void *unused)
PyObject *THPVariable_get_names(PyObject *self, void *unused)
{
HANDLE_TH_ERRORS
if (check_has_torch_function((PyObject *)self)) {
return handle_torch_function_getter(self, "names");
if (check_has_torch_function(self)) {
return handle_torch_function_getter((THPVariable*)self, "names");
}
// The long-term plan is to return a list of (python) torch.Dimname.
// However, for now, return a list of string.
size_t size = self->cdata.dim();
size_t size = ((THPVariable *)self)->cdata.dim();
THPObjectPtr tuple(PyTuple_New(size));
if (!tuple) throw python_error();
const auto dimnames = self->cdata.names();
const auto dimnames = ((THPVariable *)self)->cdata.names();
for (size_t i = 0; i < size; ++i) {
PyObject* str;
if (dimnames[i].type() == at::NameType::WILDCARD) {
@ -423,12 +423,12 @@ PyObject *THPVariable_get_names(THPVariable *self, void *unused)
END_HANDLE_TH_ERRORS
}
int THPVariable_set_names(THPVariable *self, PyObject *names) {
int THPVariable_set_names(PyObject *self, PyObject *names) {
HANDLE_TH_ERRORS
if (check_has_torch_function((PyObject *)self)) {
return handle_torch_function_setter(self, "names", names);
if (check_has_torch_function(self)) {
return handle_torch_function_setter((THPVariable*)self, "names", names);
}
auto& var = self->cdata;
auto& var = ((THPVariable *)self)->cdata;
if (names == Py_None) {
at::internal_set_names_inplace(var, at::nullopt);
} else {