frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-21 13:44:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Properly move retains_grad hook on in-place over view for base (#117552)

Browse Source 
Fixes https://github.com/pytorch/pytorch/issues/117366
Pull Request resolved: https://github.com/pytorch/pytorch/pull/117552
Approved by: https://github.com/albanD
This commit is contained in:
soulitzer
2024-01-24 16:44:19 -05:00
committed by PyTorch MergeBot
parent 9c1348feb3
commit 5b819d9ef0
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
torch/csrc/autograd/variable.cpp
View File

@ -239,6 +239,11 @@ void rebase_history(const Variable& self, Edge gradient_edge) {
at::TensorGeometry(self),
view_info.view_fn_,
std::move(gradient_edge.function));
if (self.requires_grad()) {
// If self did not previously require grad, there are no hooks to move
torch::autograd::impl::update_tensor_hooks_on_new_gradfn(
view_info.base_, view_info.base_.grad_fn(), copy_slices);
}
set_gradient_edge(view_info.base_, {std::move(copy_slices), 0});
self.grad_fn(); // trigger an update to the view's grad_fn
return;