frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-21 05:34:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE] Add regression test for aten shared build (#96697)

Browse Source 
To expose errors similar to https://github.com/pytorch/pytorch/pull/94401#issuecomment-1466654593 in OSS CI

Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain.

Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386

Pull Request resolved: https://github.com/pytorch/pytorch/pull/96697
Approved by: https://github.com/kit1980
This commit is contained in:
Nikita Shulga
2023-03-14 02:19:17 +00:00
committed by PyTorch MergeBot
parent a22b92d8ba
commit 5a8a4030a2
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.buckconfig.oss
View File

@ -14,6 +14,7 @@
[cxx] [cxx]
cxxflags = -std=c++17 cxxflags = -std=c++17
ldflags = -Wl,--no-undefined
should_remap_host_platform = true should_remap_host_platform = true
cpp = /usr/bin/clang cpp = /usr/bin/clang
cc = /usr/bin/clang cc = /usr/bin/clang

6
.github/workflows/_buck-build-test.yml vendored
View File

@ -73,7 +73,7 @@ jobs:
timeout_minutes: 10 timeout_minutes: 10
max_attempts: 5 max_attempts: 5
command: | command: |
sh scripts/buck_setup.sh bash scripts/buck_setup.sh
- name: Build tools - name: Build tools
run: | run: |
@ -122,3 +122,7 @@ jobs:
- name: Build everything - name: Build everything
run: | run: |
buck build //... --keep-going buck build //... --keep-going
- name: Build aten_cpu@shared
run: |
buck build :aten_cpu#linux-x86_64,shared