frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE][Easy][setup] use super().method(...) in command subclasses in setup.py (#156044)

Browse Source 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156044
Approved by: https://github.com/albanD
ghstack dependencies: #156741
This commit is contained in:
Xuehai Pan
2025-07-01 16:18:54 +08:00
committed by PyTorch MergeBot
parent d0a9629435
commit 3df6360e8c
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
setup.py
View File

@ -267,7 +267,6 @@ from collections import defaultdict
from typing import Any, ClassVar, IO from typing import Any, ClassVar, IO
import setuptools.command.build_ext import setuptools.command.build_ext
import setuptools.command.install
import setuptools.command.sdist import setuptools.command.sdist
import setuptools.errors import setuptools.errors
from setuptools import Command, Extension, find_packages, setup from setuptools import Command, Extension, find_packages, setup
@ -767,8 +766,7 @@ class build_ext(setuptools.command.build_ext.build_ext):
): ):
os.environ["CC"] = str(os.environ["CC"]) os.environ["CC"] = str(os.environ["CC"])
# It's an old-style class in Python 2.7... super().run()
setuptools.command.build_ext.build_ext.run(self)
if IS_DARWIN: if IS_DARWIN:
self._embed_libomp() self._embed_libomp()
@ -835,10 +833,10 @@ class build_ext(setuptools.command.build_ext.build_ext):
os.makedirs(dst_dir) os.makedirs(dst_dir)
self.copy_file(src, dst) self.copy_file(src, dst)
setuptools.command.build_ext.build_ext.build_extensions(self) super().build_extensions()
def get_outputs(self) -> list[str]: def get_outputs(self) -> list[str]:
outputs = setuptools.command.build_ext.build_ext.get_outputs(self) outputs = super().get_outputs()
outputs.append(os.path.join(self.build_lib, "caffe2")) outputs.append(os.path.join(self.build_lib, "caffe2"))
report(f"setup.py::get_outputs returning {outputs}") report(f"setup.py::get_outputs returning {outputs}")
return outputs return outputs
@ -942,11 +940,6 @@ else:
open(os.path.join(self.bdist_dir, "torch", "__init__.py"), "w").close() open(os.path.join(self.bdist_dir, "torch", "__init__.py"), "w").close()
class install(setuptools.command.install.install):
def run(self) -> None:
super().run()
class clean(Command): class clean(Command):
user_options: ClassVar[list[tuple[str, str | None, str]]] = [] user_options: ClassVar[list[tuple[str, str | None, str]]] = []
@ -1144,7 +1137,6 @@ def configure_extension_build() -> tuple[
cmdclass = { cmdclass = {
"build_ext": build_ext, "build_ext": build_ext,
"clean": clean, "clean": clean,
"install": install,
"sdist": sdist, "sdist": sdist,
} }
if wheel_concatenate is not None: if wheel_concatenate is not None: