From 3df6360e8c956edd25453b21f6b7f56e0366dcb4 Mon Sep 17 00:00:00 2001 From: Xuehai Pan Date: Tue, 1 Jul 2025 16:18:54 +0800 Subject: [PATCH] [BE][Easy][setup] use `super().method(...)` in command subclasses in `setup.py` (#156044) Pull Request resolved: https://github.com/pytorch/pytorch/pull/156044 Approved by: https://github.com/albanD ghstack dependencies: #156741 --- setup.py | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/setup.py b/setup.py index 26c694c88c98..2da08febb0ad 100644 --- a/setup.py +++ b/setup.py @@ -267,7 +267,6 @@ from collections import defaultdict from typing import Any, ClassVar, IO import setuptools.command.build_ext -import setuptools.command.install import setuptools.command.sdist import setuptools.errors from setuptools import Command, Extension, find_packages, setup @@ -767,8 +766,7 @@ class build_ext(setuptools.command.build_ext.build_ext): ): os.environ["CC"] = str(os.environ["CC"]) - # It's an old-style class in Python 2.7... - setuptools.command.build_ext.build_ext.run(self) + super().run() if IS_DARWIN: self._embed_libomp() @@ -835,10 +833,10 @@ class build_ext(setuptools.command.build_ext.build_ext): os.makedirs(dst_dir) self.copy_file(src, dst) - setuptools.command.build_ext.build_ext.build_extensions(self) + super().build_extensions() def get_outputs(self) -> list[str]: - outputs = setuptools.command.build_ext.build_ext.get_outputs(self) + outputs = super().get_outputs() outputs.append(os.path.join(self.build_lib, "caffe2")) report(f"setup.py::get_outputs returning {outputs}") return outputs @@ -942,11 +940,6 @@ else: open(os.path.join(self.bdist_dir, "torch", "__init__.py"), "w").close() -class install(setuptools.command.install.install): - def run(self) -> None: - super().run() - - class clean(Command): user_options: ClassVar[list[tuple[str, str | None, str]]] = [] @@ -1144,7 +1137,6 @@ def configure_extension_build() -> tuple[ cmdclass = { "build_ext": build_ext, "clean": clean, - "install": install, "sdist": sdist, } if wheel_concatenate is not None: