frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 12:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[2/N] Fix clang-tidy readability checks (#164652)

Browse Source 
This PR applies clang-tidy readability checks to jit sources and all headers in the code base.
`readability-redundant-inline-specifier` is suppressed because it incurs too many changes. `readability-redundant-inline-specifier` is used to detect redundant inline specifiers on function and variable declarations. There are many in-class method definitions that are marked inline.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164652
Approved by: https://github.com/Skylion007
This commit is contained in:
Yuanyuan Chen
2025-10-05 07:05:08 +00:00
committed by PyTorch MergeBot
parent 5178d0a480
commit 3c5ca685d6
89 changed files with 142 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
torch/csrc/distributed/c10d/NCCLUtils.hpp
View File

@ -367,7 +367,7 @@ class NCCLComm {
int rank_{};
// Optional reason for communicator failure, provided by ProcessGroupNCCL for
// better error messaging.
std::optional<std::string> commFailureReason_{};
std::optional<std::string> commFailureReason_;
bool initialized_{false};
// Whether this communicator is using nonblocking mode. Recorded during comm
// creation or split. For safety, we give a default value of true (more