frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-22 06:11:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply modernize-use-emplace to aten, c10, torch (#91077)

Browse Source 
Apply clang-tidy check modernize-use-emplace. This is slightly more efficient by using an inplace constructor and is the recommended style in parts of the codebase covered by clang-tidy. This just manually applies the check to rest of the codebase. Pinging @ezyang as this is related to my other PRs he reviewed like #89000

Pull Request resolved: https://github.com/pytorch/pytorch/pull/91077
Approved by: https://github.com/ezyang
This commit is contained in:
Aaron Gokaslan
2022-12-19 07:49:56 +00:00
committed by PyTorch MergeBot
parent 944519a468
commit 3916d7a575
44 changed files with 87 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
torch/csrc/jit/python/python_sugared_value.cpp
View File

@ -64,12 +64,12 @@ FunctionSchema PythonValue::getSchema(
// No type signature was provided on the callable, so make a default
// signature where each argument is typed as a Tensor
for (; names_it != param_names.end(); ++names_it) {
args.emplace_back(Argument(
args.emplace_back(
/*name=*/*names_it,
/*type=*/TensorType::get(),
/*N=*/c10::nullopt,
/*default_value=*/c10::nullopt,
/*kwarg_only=*/false));
/*kwarg_only=*/false);
}
// Use as many outputs as are requested to make the return type
@ -123,7 +123,7 @@ std::shared_ptr<SugaredValue> PythonValue::call(
size_t n_binders) {
std::vector<NamedValue> argsWithSelf;
if (moduleSelf_) {
argsWithSelf.emplace_back(NamedValue("self", moduleSelf_));
argsWithSelf.emplace_back("self", moduleSelf_);
}
argsWithSelf.insert(argsWithSelf.end(), args.begin(), args.end());
@ -795,7 +795,7 @@ std::shared_ptr<SugaredValue> ModuleValue::call(
->insertNode(calling_graph->createTupleUnpack(forward_input))
->outputs();
for (auto& output_node : output_nodes) {
pre_hook_result.emplace_back(NamedValue(output_node));
pre_hook_result.emplace_back(output_node);
}
if (args.size() != 0) { // only replace input if it existed
args = pre_hook_result;