frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-11-04 08:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add all 4 android ABIs to android build script by default

Browse Source 
The android build script (./scripts/build_pytorch_android.sh) is broken if user didn't provide the abi list.

./scripts/build_pytorch_android.sh ==> failed due to the so file for armv7 cannot be found
./scripts/build_pytorch_android.sh x86,x86_64 ==> works

This is because by default we will build 4 ABIs:
0ca0e02685/android/gradle.properties (L1)
but only one is provided in this script.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73063
This commit is contained in:
Linbin Yu
2022-02-18 17:58:37 +00:00
committed by PyTorch MergeBot
parent 99427654aa
commit 38d37436f2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/common.sh
View File

@ -29,7 +29,8 @@ check_gradle() {
}
parse_abis_list() {
ABIS_LIST="x86"
# sync with https://github.com/pytorch/pytorch/blob/0ca0e02685a9d033ac4f04e2fa5c8ba6dbc5ae50/android/gradle.properties#L1
ABIS_LIST="armeabi-v7a,arm64-v8a,x86,x86_64"
CUSTOM_ABIS_LIST=false
if [ $# -gt 0 ]; then
ABIS_LIST=$1