frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Set show_error_codes = True in mypy-strict.ini (#56616)

Browse Source 
Summary:
This should make it easier to resolve issues surfaced by https://github.com/pytorch/pytorch/issues/56290. Also see https://github.com/pytorch/pytorch/pull/56559#discussion_r617828152 for context.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56616

Test Plan:
You could add a type error in a strict-checked file like `tools/test_history.py`, and then run this command:
```
$ mypy --config=mypy-strict.ini tools/test_history.py
```

Output before this PR:
```
tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments
Found 1 error in 1 file (checked 1 source file)
```

Output after this PR:
```
tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
Found 1 error in 1 file (checked 1 source file)
```

Reviewed By: driazati

Differential Revision: D27918753

Pulled By: samestep

fbshipit-source-id: 953926e019a7669da9004fd54498b414aec777a6
This commit is contained in:
Sam Estep
2021-04-21 13:20:13 -07:00
committed by Facebook GitHub Bot
parent 5a09def9b0
commit 284e735b3f
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mypy-strict.ini
View File

@ -13,6 +13,7 @@ plugins = mypy_plugins/check_mypy_version.py
cache_dir = .mypy_cache/strict
strict_optional = True
show_error_codes = True
show_column_numbers = True
warn_no_return = True
disallow_any_unimported = True