From 251278d3853192141a961a42b631ac89c4090bc5 Mon Sep 17 00:00:00 2001 From: Jane Xu Date: Mon, 1 Nov 2021 12:23:30 -0700 Subject: [PATCH] [skip ci] set more tests with owners for distributed and elastic (#67583) Summary: It turns out my lint doesn't work on CI all the time because of shell differences. I'm working on a new more comprehensive lint in https://github.com/pytorch/pytorch/pull/66826 and it'd be nice if these could be cleared first. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: https://github.com/pytorch/pytorch/pull/67583 Reviewed By: H-Huang, mruberry Differential Revision: D32045155 Pulled By: janeyx99 fbshipit-source-id: ecfe9f008310c28e3b731e246c2b2ed0106d03b1 --- test/distributed/_sharded_tensor/ops/test_embedding.py | 2 ++ test/distributed/_sharded_tensor/ops/test_init.py | 2 ++ test/distributed/argparse_util_test.py | 1 + test/distributed/elastic/rendezvous/static_rendezvous_test.py | 2 ++ test/distributed/elastic/rendezvous/utils_test.py | 2 ++ test/distributed/launcher/api_test.py | 1 + test/distributed/launcher/bin/test_script.py | 1 + test/distributed/launcher/bin/test_script_init_method.py | 1 + .../launcher/bin/test_script_is_torchelastic_launched.py | 1 + test/distributed/launcher/bin/test_script_local_rank.py | 1 + test/distributed/launcher/launch_test.py | 1 + test/distributed/launcher/run_test.py | 1 + test/distributed/pipeline/sync/skip/test_api.py | 2 ++ test/distributed/pipeline/sync/skip/test_gpipe.py | 2 ++ test/distributed/pipeline/sync/skip/test_inspect_skip_layout.py | 2 ++ test/distributed/pipeline/sync/skip/test_leak.py | 2 ++ test/distributed/pipeline/sync/skip/test_portal.py | 2 ++ test/distributed/pipeline/sync/skip/test_stash_pop.py | 2 ++ test/distributed/pipeline/sync/skip/test_tracker.py | 2 ++ test/distributed/pipeline/sync/skip/test_verify_skippables.py | 2 ++ 20 files changed, 32 insertions(+) diff --git a/test/distributed/_sharded_tensor/ops/test_embedding.py b/test/distributed/_sharded_tensor/ops/test_embedding.py index 418699da43b4..f60187ed2ff0 100644 --- a/test/distributed/_sharded_tensor/ops/test_embedding.py +++ b/test/distributed/_sharded_tensor/ops/test_embedding.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + import sys import torch diff --git a/test/distributed/_sharded_tensor/ops/test_init.py b/test/distributed/_sharded_tensor/ops/test_init.py index 6f77beac4f31..6ba941239f34 100644 --- a/test/distributed/_sharded_tensor/ops/test_init.py +++ b/test/distributed/_sharded_tensor/ops/test_init.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + import sys import torch diff --git a/test/distributed/argparse_util_test.py b/test/distributed/argparse_util_test.py index fb63feda1d82..1902faf99273 100644 --- a/test/distributed/argparse_util_test.py +++ b/test/distributed/argparse_util_test.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: distributed"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/elastic/rendezvous/static_rendezvous_test.py b/test/distributed/elastic/rendezvous/static_rendezvous_test.py index b0694f11ef95..546dab88e946 100644 --- a/test/distributed/elastic/rendezvous/static_rendezvous_test.py +++ b/test/distributed/elastic/rendezvous/static_rendezvous_test.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: r2p"] + # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. # diff --git a/test/distributed/elastic/rendezvous/utils_test.py b/test/distributed/elastic/rendezvous/utils_test.py index 69133afaeab7..cf65d9190d23 100644 --- a/test/distributed/elastic/rendezvous/utils_test.py +++ b/test/distributed/elastic/rendezvous/utils_test.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: r2p"] + # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. # diff --git a/test/distributed/launcher/api_test.py b/test/distributed/launcher/api_test.py index 587c9fad94a3..f94e74a1288c 100644 --- a/test/distributed/launcher/api_test.py +++ b/test/distributed/launcher/api_test.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/bin/test_script.py b/test/distributed/launcher/bin/test_script.py index 58bdd3eeccf1..e880eceaa7e0 100755 --- a/test/distributed/launcher/bin/test_script.py +++ b/test/distributed/launcher/bin/test_script.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/bin/test_script_init_method.py b/test/distributed/launcher/bin/test_script_init_method.py index 299839c40759..0f57ce08d9d1 100755 --- a/test/distributed/launcher/bin/test_script_init_method.py +++ b/test/distributed/launcher/bin/test_script_init_method.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/bin/test_script_is_torchelastic_launched.py b/test/distributed/launcher/bin/test_script_is_torchelastic_launched.py index fa9729c757b6..534a8f247210 100755 --- a/test/distributed/launcher/bin/test_script_is_torchelastic_launched.py +++ b/test/distributed/launcher/bin/test_script_is_torchelastic_launched.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/bin/test_script_local_rank.py b/test/distributed/launcher/bin/test_script_local_rank.py index 7c01dcaf6029..3aa4f2c844a8 100755 --- a/test/distributed/launcher/bin/test_script_local_rank.py +++ b/test/distributed/launcher/bin/test_script_local_rank.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/launch_test.py b/test/distributed/launcher/launch_test.py index d79a18d39b99..e80041226e89 100644 --- a/test/distributed/launcher/launch_test.py +++ b/test/distributed/launcher/launch_test.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/launcher/run_test.py b/test/distributed/launcher/run_test.py index 2fdb0fdc3dec..ecfd6d929a10 100644 --- a/test/distributed/launcher/run_test.py +++ b/test/distributed/launcher/run_test.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# Owner(s): ["oncall: r2p"] # Copyright (c) Facebook, Inc. and its affiliates. # All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_api.py b/test/distributed/pipeline/sync/skip/test_api.py index 5a204e574aca..afee90fdbead 100644 --- a/test/distributed/pipeline/sync/skip/test_api.py +++ b/test/distributed/pipeline/sync/skip/test_api.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_gpipe.py b/test/distributed/pipeline/sync/skip/test_gpipe.py index e057b7f82052..5a7f753ccdc9 100644 --- a/test/distributed/pipeline/sync/skip/test_gpipe.py +++ b/test/distributed/pipeline/sync/skip/test_gpipe.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_inspect_skip_layout.py b/test/distributed/pipeline/sync/skip/test_inspect_skip_layout.py index 46455f98c020..07c2c4aa3694 100644 --- a/test/distributed/pipeline/sync/skip/test_inspect_skip_layout.py +++ b/test/distributed/pipeline/sync/skip/test_inspect_skip_layout.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_leak.py b/test/distributed/pipeline/sync/skip/test_leak.py index aa308593717f..91cbfd4960b4 100644 --- a/test/distributed/pipeline/sync/skip/test_leak.py +++ b/test/distributed/pipeline/sync/skip/test_leak.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_portal.py b/test/distributed/pipeline/sync/skip/test_portal.py index c637ac86f581..8558b974e80c 100644 --- a/test/distributed/pipeline/sync/skip/test_portal.py +++ b/test/distributed/pipeline/sync/skip/test_portal.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_stash_pop.py b/test/distributed/pipeline/sync/skip/test_stash_pop.py index ab84fdcbac6e..dcb25a5dc3c2 100644 --- a/test/distributed/pipeline/sync/skip/test_stash_pop.py +++ b/test/distributed/pipeline/sync/skip/test_stash_pop.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_tracker.py b/test/distributed/pipeline/sync/skip/test_tracker.py index 4e0d27acc0ce..ce242c4d2a42 100644 --- a/test/distributed/pipeline/sync/skip/test_tracker.py +++ b/test/distributed/pipeline/sync/skip/test_tracker.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. diff --git a/test/distributed/pipeline/sync/skip/test_verify_skippables.py b/test/distributed/pipeline/sync/skip/test_verify_skippables.py index 6f9dd510493d..c995cdbe5332 100644 --- a/test/distributed/pipeline/sync/skip/test_verify_skippables.py +++ b/test/distributed/pipeline/sync/skip/test_verify_skippables.py @@ -1,3 +1,5 @@ +# Owner(s): ["oncall: distributed"] + # Copyright 2019 Kakao Brain # # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.