frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE][Easy] use pathlib.Path instead of dirname / ".." / pardir (#129374)

Browse Source 
Changes by apply order:

1. Replace all `".."` and `os.pardir` usage with `os.path.dirname(...)`.
2. Replace nested `os.path.dirname(os.path.dirname(...))` call with `str(Path(...).parent.parent)`.
3. Reorder `.absolute()` ~/ `.resolve()`~ and `.parent`: always resolve the path first.

    `.parent{...}.absolute()` -> `.absolute().parent{...}`

4. Replace chained `.parent x N` with `.parents[${N - 1}]`: the code is easier to read (see 5.)

    `.parent.parent.parent.parent` -> `.parents[3]`

5. ~Replace `.parents[${N - 1}]` with `.parents[${N} - 1]`: the code is easier to read and does not introduce any runtime overhead.~

    ~`.parents[3]` -> `.parents[4 - 1]`~

6. ~Replace `.parents[2 - 1]` with `.parent.parent`: because the code is shorter and easier to read.~

Pull Request resolved: https://github.com/pytorch/pytorch/pull/129374
Approved by: https://github.com/justinchuby, https://github.com/malfet
This commit is contained in:
Xuehai Pan
2024-12-22 00:44:29 +08:00
committed by PyTorch MergeBot
parent 197954e14b
commit 2293fe1024
62 changed files with 119 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/compile_tests/update_failures.py
View File

@ -194,7 +194,7 @@ if __name__ == "__main__":
"filename",
nargs="?",
default=str(
Path(__file__).absolute().parent.parent.parent
Path(__file__).absolute().parents[2]
/ "torch/testing/_internal/dynamo_test_failures.py"
),
help="Optional path to dynamo_test_failures.py",
@ -203,7 +203,7 @@ if __name__ == "__main__":
parser.add_argument(
"test_dir",
nargs="?",
default=str(Path(__file__).absolute().parent.parent.parent / "test"),
default=str(Path(__file__).absolute().parents[2] / "test"),
help="Optional path to test folder",
)
parser.add_argument(