frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BE]: Optimize min/max/sum comprehensions C419 (#123960)

Browse Source 
Automatic fixes that replaces certain list comprehensions with generator ones where appropriate so that they are immediately consumed. This is preview functionality in ruff for rule C419 and it was automatically applied.

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/123960
Approved by: https://github.com/malfet
This commit is contained in:
Aaron Gokaslan
2024-04-12 23:54:11 +00:00
committed by PyTorch MergeBot
parent 961eb39348
commit 1d6c5972c1
42 changed files with 89 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/quantization/fx/test_model_report_fx.py
View File

@ -1346,7 +1346,7 @@ class TestFxDetectInputWeightEqualization(QuantizationTestCase):
# assert that each of the desired modules have the observers inserted
for fqn, module in prepared_for_callibrate_model.named_modules():
# check if module is a supported module
is_in_include_list = sum([isinstance(module, x) for x in mods_to_check]) > 0
is_in_include_list = sum(isinstance(module, x) for x in mods_to_check) > 0
if is_in_include_list:
# make sure it has the observer attribute
@ -1563,7 +1563,7 @@ class TestFxDetectOutliers(QuantizationTestCase):
obs_name_to_find = InputWeightEqualizationDetector.DEFAULT_PRE_OBSERVER_NAME
number_of_obs_found = sum(
[1 if obs_name_to_find in str(node.target) else 0 for node in prepared_for_callibrate_model.graph.nodes]
1 if obs_name_to_find in str(node.target) else 0 for node in prepared_for_callibrate_model.graph.nodes
)
self.assertEqual(number_of_obs_found, correct_number_of_obs_inserted)
@ -1753,7 +1753,7 @@ class TestFxDetectOutliers(QuantizationTestCase):
assert sum(counts_info) >= 2
# half of the recorded max values should be what we set
matched_max = sum([val == 3.28e8 for val in module_dict[OutlierDetector.MAX_VALS_KEY]])
matched_max = sum(val == 3.28e8 for val in module_dict[OutlierDetector.MAX_VALS_KEY])
self.assertEqual(matched_max, param_size / 2)