mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
[ci] use lintrunner in CI
This changes our lint workflows to use lintrunner for the linters that are currently supported + some random fixes to make things lint clean on master + changes to Makefile to use lintrunner Pull Request resolved: https://github.com/pytorch/pytorch/pull/68460 Approved by: https://github.com/t10-13rocket, https://github.com/seemethere, https://github.com/janeyx99
This commit is contained in:
committed by
PyTorch MergeBot
parent
54bd9e0402
commit
1c60b9aaa5
52
Makefile
52
Makefile
@ -1,5 +1,6 @@
|
||||
# This makefile does nothing but delegating the actual building to cmake.
|
||||
PYTHON = python3
|
||||
PIP = pip3
|
||||
|
||||
all:
|
||||
@mkdir -p build && cd build && cmake .. $(shell $(PYTHON) ./scripts/get_python_cmake_flags.py) && $(MAKE)
|
||||
@ -51,12 +52,7 @@ shellcheck:
|
||||
--job 'shellcheck'
|
||||
|
||||
setup_lint:
|
||||
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
|
||||
--job 'flake8-py3' --step 'Install dependencies' --no-quiet
|
||||
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
|
||||
--job 'cmakelint' --step 'Install dependencies' --no-quiet
|
||||
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
|
||||
--job 'mypy' --step 'Install dependencies' --no-quiet
|
||||
$(PIP) install lintrunner
|
||||
$(PYTHON) tools/actions_local_runner.py --file .github/workflows/lint.yml \
|
||||
--job 'shellcheck' --step 'Install Jinja2' --no-quiet
|
||||
|
||||
@ -71,8 +67,6 @@ setup_lint:
|
||||
--job 'shellcheck' --step 'Install ShellCheck' --no-quiet; \
|
||||
fi
|
||||
$(PYTHON) -mpip install jinja2 --user
|
||||
$(PYTHON) -mpip install -r tools/linter/clang_tidy/requirements.txt --user
|
||||
$(PYTHON) -m tools.linter.install.clang_tidy
|
||||
|
||||
quick_checks:
|
||||
# TODO: This is broken when 'git config submodule.recurse' is 'true' since the
|
||||
@ -80,41 +74,7 @@ quick_checks:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
--file .github/workflows/lint.yml \
|
||||
--job 'quick-checks' \
|
||||
--step 'Ensure no trailing spaces' \
|
||||
--step 'Ensure no tabs' \
|
||||
--step 'Ensure no non-breaking spaces' \
|
||||
--step 'Ensure canonical include' \
|
||||
--step 'Ensure no versionless Python shebangs' \
|
||||
--step 'Ensure no unqualified noqa' \
|
||||
--step 'Ensure GitHub PyPi dependencies are pinned' \
|
||||
--step 'Ensure no unqualified type ignore' \
|
||||
--step 'Ensure no direct cub include' \
|
||||
--step 'Ensure correct trailing newlines' \
|
||||
--step 'Ensure no raw cuda api calls'
|
||||
|
||||
flake8:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
$(CHANGED_ONLY) \
|
||||
$(REF_BRANCH) \
|
||||
--job 'flake8-py3'
|
||||
|
||||
mypy:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
$(CHANGED_ONLY) \
|
||||
$(REF_BRANCH) \
|
||||
--job 'mypy'
|
||||
|
||||
cmakelint:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
--file .github/workflows/lint.yml \
|
||||
--job 'cmakelint' \
|
||||
--step 'Run cmakelint'
|
||||
|
||||
clang-tidy:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
$(CHANGED_ONLY) \
|
||||
$(REF_BRANCH) \
|
||||
--job 'clang-tidy'
|
||||
--step 'Ensure no versionless Python shebangs'
|
||||
|
||||
toc:
|
||||
@$(PYTHON) tools/actions_local_runner.py \
|
||||
@ -122,7 +82,9 @@ toc:
|
||||
--job 'toc' \
|
||||
--step "Regenerate ToCs and check that they didn't change"
|
||||
|
||||
lint: flake8 mypy quick_checks cmakelint shellcheck
|
||||
lint: quick_checks shellcheck
|
||||
lintrunner
|
||||
|
||||
quicklint: CHANGED_ONLY=--changed-only
|
||||
quicklint: mypy flake8 quick_checks cmakelint shellcheck clang-tidy
|
||||
quicklint: quick_checks shellcheck
|
||||
lintrunner
|
||||
|
Reference in New Issue
Block a user