frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

add pointer to windows FAQ in contributing.md (#17450)

Browse Source 
Summary:
" ProTip! Great commit summaries contain fewer than 50 characters. Place extra information in the extended description."
lol
Pull Request resolved: https://github.com/pytorch/pytorch/pull/17450

Differential Revision: D14206500

Pulled By: suo

fbshipit-source-id: af7ffe299f8c8f04fa8e720847a1f6d576ebafc1
This commit is contained in:
Michael Suo
2019-02-24 23:00:10 -08:00
committed by Facebook Github Bot
parent d76b9395a0
commit 15840e30dc
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@ -335,6 +335,9 @@ Hope this helps, and thanks for considering to contribute.
## Windows development tips ## Windows development tips
For building from source on Windows, consult
[our documentation](https://pytorch.org/docs/stable/notes/windows.html) on it.
Occasionally, you will write a patch which works on Linux, but fails CI on Windows. Occasionally, you will write a patch which works on Linux, but fails CI on Windows.
There are a few aspects in which MSVC (the Windows compiler toolchain we use) is stricter There are a few aspects in which MSVC (the Windows compiler toolchain we use) is stricter
than Linux, which are worth keeping in mind when fixing these problems. than Linux, which are worth keeping in mind when fixing these problems.