frozenleaves/pytorch
1
0
Fork 0
mirror of https://github.com/pytorch/pytorch.git synced 2025-10-20 21:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[jit][perf] Reduce lookupInModule overhead. (#119145)

Browse Source 
It's inefficient to split remaining parts of the module name by '.' just to join it back again. Instead it's more idiomatic and efficient to use `maxsplit=1` to ensure that all remaining parts remain intact. This improves best case time and space complexity since scan can terminate on first encountered `.` and only 2 parts are returned in a list.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/119145
Approved by: https://github.com/Skylion007
This commit is contained in:
Taras Tsugrii
2024-02-05 18:00:55 +00:00
committed by PyTorch MergeBot
parent fa8d97776c
commit 124a54ef16
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
torch/_jit_internal.py
View File

@ -105,9 +105,7 @@ def createResolutionCallbackFromEnv(lookup_base):
def lookupInModule(qualified_name, module):
if "." in qualified_name:
parts = qualified_name.split(".")
base = parts[0]
remaining_pieces = ".".join(parts[1:])
base, remaining_pieces = qualified_name.split(".", maxsplit=1)
module_value = getattr(module, base)
return lookupInModule(remaining_pieces, module_value)
else: