Use torch_compile_options for c10 libraries (#147821)

c10, c10_cuda, c10_hip and c10_xpu are given additional compile options by torch_compile_options, which are more restrictive and can help reveal potential bugs inside the code.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/147821
Approved by: https://github.com/guangyey, https://github.com/malfet
This commit is contained in:
cyy
2025-03-18 01:54:19 +00:00
committed by PyTorch MergeBot
parent 60523540f1
commit 1096443467
4 changed files with 4 additions and 1 deletions

View File

@ -50,7 +50,7 @@ endif()
)
if(NOT BUILD_LIBTORCHLESS)
add_library(c10 ${C10_SRCS} ${C10_HEADERS})
target_compile_options_if_supported(c10 "-Wdeprecated")
torch_compile_options(c10)
if(HAVE_SOVERSION)
set_target_properties(c10 PROPERTIES
VERSION ${TORCH_VERSION} SOVERSION ${TORCH_SOVERSION})

View File

@ -56,6 +56,7 @@ set(CUDA_LINK_LIBRARIES_KEYWORD PRIVATE)
if(NOT BUILD_LIBTORCHLESS)
torch_cuda_based_add_library(c10_cuda ${C10_CUDA_SRCS} ${C10_CUDA_HEADERS})
torch_compile_options(c10_cuda)
set(CUDA_LINK_LIBRARIES_KEYWORD)
# If building shared library, set dllimport/dllexport proper.
target_compile_options(c10_cuda PRIVATE "-DC10_CUDA_BUILD_MAIN_LIB")

View File

@ -33,6 +33,7 @@ file(GLOB_RECURSE C10_HIP_HEADERS *.h)
if(NOT BUILD_LIBTORCHLESS)
hip_add_library(c10_hip ${C10_HIP_SRCS} ${C10_HIP_HEADERS})
torch_compile_options(c10_hip)
# Propagate HIP_CXX_FLAGS that were set from Dependencies.cmake
target_compile_options(c10_hip PRIVATE ${HIP_CXX_FLAGS})

View File

@ -31,6 +31,7 @@ set(C10_XPU_HEADERS
)
if(NOT BUILD_LIBTORCHLESS)
add_library(c10_xpu ${C10_XPU_SRCS} ${C10_XPU_HEADERS})
torch_compile_options(c10_xpu)
target_compile_options(c10_xpu PRIVATE "-DC10_XPU_BUILD_MAIN_LIB")
# Enable hidden visibility if compiler supports it.
if(${COMPILER_SUPPORTS_HIDDEN_VISIBILITY})