mirror of
https://github.com/pytorch/pytorch.git
synced 2025-10-20 12:54:11 +08:00
Fix obviously-broken .clang-tidy files (#28547)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/28547 Pull Request resolved: https://github.com/pytorch/glow/pull/3672 See D18090864 for more background. The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended. Perhaps this means it's time to lint the linter config :-) Test Plan: Here's the resulting output for `~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy` related to each file touched: `fbcode/admarket/intent/.clang-tidy`: P119723794 `fbcode/caffe2/.clang-tidy`: P119723978 `fbcode/glow/glow/.clang-tidy`: P119724081 `fbcode/ice_palace/.clang-tidy`: P119724774 `fbcode/unified_graph/aggregator/.clang-tidy`: P119724375 `xplat/caffe2/.clang-tidy`: P119724464 `xplat/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/mcfcpp/.clang-tidy. ``` `xplat/wa-msys/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/wa-msys/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/wa-msys/mcfcpp/.clang-tidy. ``` Reviewed By: soumith Differential Revision: D18092684 fbshipit-source-id: 951307d125c0346322cb2c636c0300004a48d7a9
This commit is contained in:
committed by
Facebook Github Bot
parent
f5ea2ca34a
commit
0c7537c409
55
.clang-tidy
55
.clang-tidy
@ -1,32 +1,31 @@
|
||||
---
|
||||
# NOTE there must be no spaces before the '-', so put the comma first.
|
||||
Checks: '
|
||||
-*
|
||||
,bugprone-*
|
||||
,-bugprone-forward-declaration-namespace
|
||||
,-bugprone-macro-parentheses
|
||||
,-bugprone-lambda-function-name
|
||||
,cppcoreguidelines-*
|
||||
,-cppcoreguidelines-interfaces-global-init
|
||||
,-cppcoreguidelines-owning-memory
|
||||
,-cppcoreguidelines-pro-bounds-array-to-pointer-decay
|
||||
,-cppcoreguidelines-pro-bounds-constant-array-index
|
||||
,-cppcoreguidelines-pro-bounds-pointer-arithmetic
|
||||
,-cppcoreguidelines-pro-type-cstyle-cast
|
||||
,-cppcoreguidelines-pro-type-reinterpret-cast
|
||||
,-cppcoreguidelines-pro-type-static-cast-downcast
|
||||
,-cppcoreguidelines-pro-type-union-access
|
||||
,-cppcoreguidelines-pro-type-vararg
|
||||
,-cppcoreguidelines-special-member-functions
|
||||
,hicpp-exception-baseclass
|
||||
,hicpp-avoid-goto
|
||||
,modernize-*
|
||||
,-modernize-return-braced-init-list
|
||||
,-modernize-use-auto
|
||||
,-modernize-use-default-member-init
|
||||
,-modernize-use-using
|
||||
,performance-*
|
||||
,-performance-noexcept-move-constructor
|
||||
# NOTE there must be no spaces before the '-', so put the comma last.
|
||||
Checks: '-*,
|
||||
bugprone-*,
|
||||
-bugprone-forward-declaration-namespace,
|
||||
-bugprone-macro-parentheses,
|
||||
-bugprone-lambda-function-name,
|
||||
cppcoreguidelines-*,
|
||||
-cppcoreguidelines-interfaces-global-init,
|
||||
-cppcoreguidelines-owning-memory,
|
||||
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
|
||||
-cppcoreguidelines-pro-bounds-constant-array-index,
|
||||
-cppcoreguidelines-pro-bounds-pointer-arithmetic,
|
||||
-cppcoreguidelines-pro-type-cstyle-cast,
|
||||
-cppcoreguidelines-pro-type-reinterpret-cast,
|
||||
-cppcoreguidelines-pro-type-static-cast-downcast,
|
||||
-cppcoreguidelines-pro-type-union-access,
|
||||
-cppcoreguidelines-pro-type-vararg,
|
||||
-cppcoreguidelines-special-member-functions,
|
||||
hicpp-exception-baseclass,
|
||||
hicpp-avoid-goto,
|
||||
modernize-*,
|
||||
-modernize-return-braced-init-list,
|
||||
-modernize-use-auto,
|
||||
-modernize-use-default-member-init,
|
||||
-modernize-use-using,
|
||||
performance-*,
|
||||
-performance-noexcept-move-constructor,
|
||||
'
|
||||
HeaderFilterRegex: 'torch/csrc/.*'
|
||||
AnalyzeTemporaryDtors: false
|
||||
|
Reference in New Issue
Block a user