From 02dd7a7803fee02a77d3c5a4512bb59121c5d9fd Mon Sep 17 00:00:00 2001 From: albanD Date: Tue, 28 Jan 2025 23:22:21 +0000 Subject: [PATCH] Extend abi-stable nitpick message to all the c stable files (#145862) Pull Request resolved: https://github.com/pytorch/pytorch/pull/145862 Approved by: https://github.com/ezyang --- .github/nitpicks.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/nitpicks.yml b/.github/nitpicks.yml index 6d5fcc1dd4d7..1d08a36abf1d 100644 --- a/.github/nitpicks.yml +++ b/.github/nitpicks.yml @@ -5,7 +5,8 @@ - 'aten/src/ATen/native/native_functions.yaml' - markdown: | - ## Attention! torch/csrc/inductor/aoti_torch/c/shim.h was changed + ## Attention! PyTorch one of the C-stable API file was changed You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function. pathFilter: - - 'torch/csrc/inductor/aoti_torch/c/shim.h' + - 'torch/csrc/inductor/aoti_torch/c/*' + - 'torch/csrc/inductor/aoti_torch/generated/*'