From 2ce55057999bdf1c9bf26cb5f000a8a9fb97e2d9 Mon Sep 17 00:00:00 2001
From: Logan Adams <114770087+loadams@users.noreply.github.com>
Date: Mon, 9 Jun 2025 15:42:55 -0700
Subject: [PATCH] Move pytest pinning from individual tests to
 requirements-dev.txt until fixed. (#7327)

pytest 8.4.0 seems to break a number of our tests, rather than pinning
in each individually, we should just put this in the requirements file
until we resolve the issue.

---------

Co-authored-by: Olatunji Ruwase <tjruwase@gmail.com>
---
 .github/workflows/cpu-torch-latest.yml   | 1 -
 .github/workflows/hpu-gaudi2-nightly.yml | 1 -
 .github/workflows/hpu-gaudi2.yml         | 1 -
 requirements/requirements-dev.txt        | 2 +-
 4 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/.github/workflows/cpu-torch-latest.yml b/.github/workflows/cpu-torch-latest.yml
index 5f4e2b1a3..75507da4b 100644
--- a/.github/workflows/cpu-torch-latest.yml
+++ b/.github/workflows/cpu-torch-latest.yml
@@ -48,7 +48,6 @@ jobs:
 
       - name: Install deepspeed
         run: |
-          pip install pytest==8.3.5
           pip install .[dev,autotuning]
           ds_report
 
diff --git a/.github/workflows/hpu-gaudi2-nightly.yml b/.github/workflows/hpu-gaudi2-nightly.yml
index b86ee8d4e..9a25d3205 100644
--- a/.github/workflows/hpu-gaudi2-nightly.yml
+++ b/.github/workflows/hpu-gaudi2-nightly.yml
@@ -70,7 +70,6 @@ jobs:
       - name: Install deepspeed
         run: |
           pip install .[dev,autotuning]
-          pip install pytest==8.3.5 # pin pytest to avoid issues with pytest 8.4.0
           ds_report
 
       - name: Python environment
diff --git a/.github/workflows/hpu-gaudi2.yml b/.github/workflows/hpu-gaudi2.yml
index f01506c2f..f188b6b60 100644
--- a/.github/workflows/hpu-gaudi2.yml
+++ b/.github/workflows/hpu-gaudi2.yml
@@ -121,7 +121,6 @@ jobs:
       - name: Install deepspeed
         run: |
           pip install .[dev,autotuning]
-          pip install pytest==8.3.5 # pin pytest to avoid issues with pytest 8.4.0
           ds_report
 
       - name: Python environment
diff --git a/requirements/requirements-dev.txt b/requirements/requirements-dev.txt
index eecb951d2..10a24fc69 100644
--- a/requirements/requirements-dev.txt
+++ b/requirements/requirements-dev.txt
@@ -7,7 +7,7 @@ future
 importlib-metadata>=4
 mup
 pre-commit>=3.2.0
-pytest>=7.2.0
+pytest>=7.2.0,<8.4.0
 pytest-forked
 pytest-randomly
 pytest-xdist